Skip to content

fix(checkbox): not marked as touched immediately on blur with OnPush change detection #15001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2019
Merged

fix(checkbox): not marked as touched immediately on blur with OnPush change detection #15001

merged 1 commit into from
Jan 30, 2019
+37 −3

Conversation

crisbeto
Copy link
Member

Fixes a checkbox which is blurred inside a component with OnPush change detection not being marked as touched.

Fixes #14980.

@crisbeto
fix(checkbox): not marked as touched immediately on blur with OnPush …

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
bac4d9f 
…change detection

Fixes a checkbox which is blurred inside a component with `OnPush` change detection not being marked as touched.

Fixes angular#14980.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jan 29, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 29, 2019
jelbourn
jelbourn approved these changes Jan 29, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 29, 2019
@mmalerba mmalerba merged commit 01af4db into angular:master Jan 30, 2019
mmalerba pushed a commit that referenced this pull request Feb 4, 2019
@crisbeto @mmalerba
fix(checkbox): not marked as touched immediately on blur with OnPush …
916c532 
…change detection (#15001)

Fixes a checkbox which is blurred inside a component with `OnPush` change detection not being marked as touched.

Fixes #14980.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

form outouched status and checkboxes
4 participants
@crisbeto @jelbourn @googlebot @mmalerba