-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow CSS variables in color palettes #15107
Labels
P2
The issue is important to a large percentage of users, with a workaround
Comments
crisbeto
added a commit
to crisbeto/material2
that referenced
this issue
Feb 10, 2019
* Adds an extra theme to the build that will allow us to verify that everything still works if somebody passes in the palette colors as CSS variables. * Fixes a handful of places where Sass would either throw an error or would produce invalid CSS. Fixes angular#15107.
crisbeto
added a commit
to crisbeto/material2
that referenced
this issue
Feb 10, 2019
* Adds an extra theme to the build that will allow us to verify that everything still works if somebody passes in the palette colors as CSS variables. * Fixes a handful of places where Sass would either throw an error or would produce invalid CSS. Fixes angular#15107.
crisbeto
added a commit
to crisbeto/material2
that referenced
this issue
Feb 10, 2019
* Adds an extra theme to the build that will allow us to verify that everything still works if somebody passes in the palette colors as CSS variables. * Fixes a handful of places where Sass would either throw an error or would produce invalid CSS. Fixes angular#15107.
crisbeto
added a commit
to crisbeto/material2
that referenced
this issue
Feb 10, 2019
* Adds an extra theme to the build that will allow us to verify that everything still works if somebody passes in the palette colors as CSS variables. * Fixes a handful of places where Sass would either throw an error or would produce invalid CSS. Fixes angular#15107.
crisbeto
added a commit
to crisbeto/material2
that referenced
this issue
Feb 11, 2019
* Adds an extra theme to the build that will allow us to verify that everything still works if somebody passes in the palette colors as CSS variables. * Fixes a handful of places where Sass would either throw an error or would produce invalid CSS. Fixes angular#15107.
jelbourn
pushed a commit
that referenced
this issue
Feb 13, 2019
* Adds an extra theme to the build that will allow us to verify that everything still works if somebody passes in the palette colors as CSS variables. * Fixes a handful of places where Sass would either throw an error or would produce invalid CSS. Fixes #15107.
jelbourn
pushed a commit
that referenced
this issue
Feb 20, 2019
* Adds an extra theme to the build that will allow us to verify that everything still works if somebody passes in the palette colors as CSS variables. * Fixes a handful of places where Sass would either throw an error or would produce invalid CSS. Fixes #15107.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Please describe the feature you would like to request.
A color palette has to be defined by by using COLOR values, but doesn't allow CSS variables.
Example:
is invalid.
What is the use-case or motivation for this proposal?
We have an application, where we defined the colors as CSS variables, so we can switch for different brands.
Is there anything else we should know?
Only two places are depending on the colors:
_theming.scss 2542
_theming.scss 2603
If these lines are commented out, a
palette
can be used withCSS variables
.I know CSS variables are not supported by Internet explorer. However just changing these two lines (the calendar disables state), would allow their usage!
The text was updated successfully, but these errors were encountered: