fix(table): add missing rowgroup roles #15131
Merged
+89
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelbourn
added
Accessibility
googlebot
added
the
cla: yes
jelbourn
force-pushed
the
table-rowgroup-roles
branch
from
f0832df to
20516fc
Compare
The native cdk-table adds thead, tbody, and tfoot elements but was omitting the "rowgroup" role from these. This is necessary since we also specifically add roles to all of the other table elements. This also marks thead and tfoot as `display: none` when there are no corresponding rows.
jelbourn
force-pushed
the
table-rowgroup-roles
branch
from
20516fc to
b354ddc
Compare
|
@andrewseguin please take a look at the new changes I've added to this PR |
jelbourn
added a commit
that referenced
this pull request
Feb 20, 2019
The native cdk-table adds thead, tbody, and tfoot elements but was omitting the "rowgroup" role from these. This is necessary since we also specifically add roles to all of the other table elements. This also marks thead and tfoot as `display: none` when there are no corresponding rows.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The native cdk-table adds thead, tbody, and tfoot elements but was
omitting the "rowgroup" role from these. This is necessary since we also
specifically add roles to all of the other table elements.