README.md

@@ -140,9 +140,7 @@ any of the below commands to make sure you are using the right version.
 - `ibazel test test:unit_test` executes the unit tests in watch mode (use `bazel test test:unit_test` for a single run),
 - `bazel test test:e2e_test` executes the e2e tests,
 - `bazel test test:golden_test` executes the golden tests,
-- `node check_format.js` checks the source code formatting using
-  `clang-format`,
-- `yarn test` runs unit tests, e2e tests and checks the source code formatting.
+- `yarn test` runs unit tests and e2e tests.
 
 ### Debugging
 

demo/package.json

@@ -10,7 +10,7 @@
     "demo": "node --preserve-symlinks build/demo.js -- --outDir `pwd`/tsickle-out"
   },
   "dependencies": {
-    "minimist": "^1.2.0",
+    "minimist": "^1.2.3",
     "tsickle": "^0.37.0",
     "typescript": "~3.5.3"
   },

demo/yarn.lock

@@ -7,11 +7,6 @@
   resolved "https://registry.yarnpkg.com/@types/minimist/-/minimist-1.2.0.tgz#69a23a3ad29caf0097f06eda59b361ee2f0639f6"
   integrity sha1-aaI6OtKcrwCX8G7aWbNh7i8GOfY=
 
-"@types/node@*":
-  version "12.7.5"
-  resolved "https://registry.yarnpkg.com/@types/node/-/node-12.7.5.tgz#e19436e7f8e9b4601005d73673b6dc4784ffcc2f"
-  integrity sha512-9fq4jZVhPNW8r+UYKnxF1e2HkDWOWKM5bC2/7c9wPV835I0aOrVbS/Hw/pWPk2uKrNXQqg9Z959Kz+IYDd5p3w==
-
 "@types/node@^10.5.6":
   version "10.14.18"
   resolved "https://registry.yarnpkg.com/@types/node/-/node-10.14.18.tgz#b7d45fc950e6ffd7edc685e890d13aa7b8535dce"
@@ -22,10 +17,10 @@ minimist@0.0.8:
   resolved "https://registry.yarnpkg.com/minimist/-/minimist-0.0.8.tgz#857fcabfc3397d2625b8228262e86aa7a011b05d"
   integrity sha1-hX/Kv8M5fSYluCKCYuhqp6ARsF0=
 
-minimist@^1.2.0:
-  version "1.2.0"
-  resolved "https://registry.yarnpkg.com/minimist/-/minimist-1.2.0.tgz#a35008b20f41383eec1fb914f4cd5df79a264284"
-  integrity sha1-o1AIsg9BOD7sH7kU9M1d95omQoQ=
+minimist@^1.2.0, minimist@^1.2.3:
+  version "1.2.3"
+  resolved "https://registry.yarnpkg.com/minimist/-/minimist-1.2.3.tgz#3db5c0765545ab8637be71f333a104a965a9ca3f"
+  integrity sha512-+bMdgqjMN/Z77a6NlY/I3U5LlRDbnmaAk6lDveAPKwSpcPM4tKAuYsvYF8xjhOPXhOYGe/73vVLVez5PW+jqhw==
 
 mkdirp@^0.5.1:
   version "0.5.1"

package.json

@@ -1,6 +1,6 @@
 {
   "name": "tsickle",
-  "version": "0.37.1",
+  "version": "0.39.0",
   "description": "Transpile TypeScript code to JavaScript with Closure annotations.",
   "main": "src/tsickle.js",
   "typings": "src/tsickle.d.ts",
@@ -21,21 +21,19 @@
     "@types/glob": "5.0.35",
     "@types/jasmine": "2.8.8",
     "@types/node": "^10.5.6",
-    "clang-format": "^1.2.4",
     "diff-match-patch": "^1.0.1",
     "glob": "7.1.2",
     "google-closure-compiler": "^20190929.0.0",
     "jasmine": "3.1.0",
-    "prettier": "1.14.0",
     "source-map": "^0.7.3",
     "source-map-support": "^0.5.6",
     "tslib": "1.11",
     "tslint": "5.11.0",
-    "typescript": "3.8.2"
+    "typescript": "3.9"
   },
   "scripts": {
     "build": "bazel build //:npm_package",
-    "lint": "node check_format.js && tslint -c tslint.json -p tsconfig.json",
+    "lint": "tslint -c tslint.json -p tsconfig.json",
     "test": "yarn lint && bazel test ..."
   },
   "repository": {

src/closure_externs.js

@@ -112,3 +112,6 @@ function CanvasDrawImage() {}
 function CryptoKey() {};
 /** @constructor */
 function CryptoKeyPair() {};
+
+/** @typedef {!{handleEvent: function(Event):void}} */
+var EventListenerObject;

src/fileoverview_comment_transformer.ts

@@ -62,24 +62,30 @@ function augmentFileoverviewComments(
   }
 
   // Ensure our suppressions are included in the @suppress tag:
-  // 1) Suppress checkTypes.  We believe the code has already been type-checked by TypeScript,
-  // and we cannot model all the TypeScript type decisions in Closure syntax.
+  // * Suppress checkTypes.  We believe the code has already been type-checked
+  // by TypeScript, and we cannot model all the TypeScript type decisions in
+  // Closure syntax.
   suppressions.add('checkTypes');
-  // 2) Suppress extraRequire.  We remove extra requires at the TypeScript level, so any require
-  // that gets to the JS level is a load-bearing require.
+  // * Suppress extraRequire.  We remove extra requires at the TypeScript level,
+  // so any require that gets to the JS level is a load-bearing require.
   suppressions.add('extraRequire');
-  // 3) Suppress uselessCode.  We emit an "if (false)" around type declarations,
+  // * Types references are propagated between files even when they are not
+  // directly imported. While these are violations of the "missing require"
+  // rules they are believed to be safe.
+  suppressions.add('missingRequire');
+  // * Suppress uselessCode.  We emit an "if (false)" around type declarations,
   // which is flagged as unused code unless we suppress it.
   suppressions.add('uselessCode');
-  // 4) Suppress some checks for user errors that TS already checks.
+  // * Suppress some checks for user errors that TS already checks.
   suppressions.add('missingReturn');
   suppressions.add('unusedPrivateMembers');
-  // 5) Suppress checking for @override, because TS doesn't model it.
+  // * Suppress checking for @override, because TS doesn't model it.
   suppressions.add('missingOverride');
-  // 6) Suppress constantProperty checking, which errors when a namespace is
+  // * Suppress constantProperty checking, which errors when a namespace is
   // reopened. Namespace reopening happens when one writes namespace foo {}
   // or namespace foo.* {} more than once.
   suppressions.add('constantProperty');
+
   suppressTag.type = Array.from(suppressions.values()).sort().join(',');
 
   return tags;