Skip to content
This repository has been archived by the owner on May 20, 2023. It is now read-only.

ChangeDetectionStrategy.OnPush missing in a few components #480

Open
vlin59 opened this issue Oct 15, 2020 · 1 comment
Open

ChangeDetectionStrategy.OnPush missing in a few components #480

vlin59 opened this issue Oct 15, 2020 · 1 comment

Comments

@vlin59
Copy link

vlin59 commented Oct 15, 2020

I'm on angular: 6.0.0 and angular_components: 1.0.1.

Using the MaterialSelectComponent gives this compile-time warning when the parent uses the OnPush Change Detection Strategy.

"MaterialSelectComponent" doesn't use "ChangeDetectionStrategy.OnPush", but is used by a component that does.

ReorderListComponent and MaterialSelectSearchboxComponent appears to also require it.

I haven't come across anything else in my codebase but more could be missing.

@GZGavinZhao
Copy link

Fixed in the latest, Angular-7-compatible ngcomponents

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants