Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[just-omit] webpack import error #539

Open
marcebdev opened this issue Mar 10, 2023 · 3 comments
Open

[just-omit] webpack import error #539

marcebdev opened this issue Mar 10, 2023 · 3 comments

Comments

@marcebdev
Copy link

When trying to import packages I see an Uncaught TypeError: just_omit__WEBPACK_IMPORTED_MODULE_0___default(...) is not a function error when doing `import omit from 'just-omit'

Using:
"just-omit": "^2.2.0"
"webpack": "4.41.5"
"react-scripts": "3.4.0"

Not sure what's causing the import not to work on this version of webpack, I believe it doesn't support ES6 but as far as I can tell this package doesn't need ES6 it should be fine on ES5

@vpckso
Copy link

vpckso commented Mar 24, 2023

I have same problem, and I solved by
import omit from 'just-omit/index.mjs'

@marcebdev
Copy link
Author

marcebdev commented Aug 23, 2023

I have same problem, and I solved by import omit from 'just-omit/index.mjs'

This seems to solve that but in TS envs the issue then becomes the types aren't imported when trying to import directly from /index.mjs

Any thoughts @angus-c?

@marcebdev
Copy link
Author

I've dug a little deeper here and it seems that downgrading the just packages to a version that includes only the .js file instead of the .cjs & .mjs files solves this.

It must be something to do with either improper exports, Jest, or somewhere in-between (maybe runtime is grabbing the func from .mjs but for some reason Jest is trying to import from .cjs or something (complaining about the default export.)

I can say I'm seeing this with Jest@24 I'd love to test on newer versions, and imagine both newer Webpack versions & Jest versions don't have this error or it would be more widespread, but for the time being the repo in question (which I've tried out this lib with) is stuck on older versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants