no-inner-declarations.js

/**
 * @fileoverview Tests for no-inner-declarations rule.
 * @author Brandon Mills
 */
"use strict";

//------------------------------------------------------------------------------
// Requirements
//------------------------------------------------------------------------------

const rule = require("../../../lib/rules/no-inner-declarations"),
    { RuleTester } = require("../../../lib/rule-tester");

//------------------------------------------------------------------------------
// Tests
//------------------------------------------------------------------------------

const ruleTester = new RuleTester();

ruleTester.run("no-inner-declarations", rule, {

    // Examples of code that should not trigger the rule
    valid: [
        "function doSomething() { }",
        "function doSomething() { function somethingElse() { } }",
        "(function() { function doSomething() { } }());",
        "if (test) { var fn = function() { }; }",
        "if (test) { var fn = function expr() { }; }",
        "function decl() { var fn = function expr() { }; }",
        "function decl(arg) { var fn; if (arg) { fn = function() { }; } }",
        { code: "var x = {doSomething() {function doSomethingElse() {}}}", parserOptions: { ecmaVersion: 6 } },
        { code: "function decl(arg) { var fn; if (arg) { fn = function expr() { }; } }", parserOptions: { ecmaVersion: 6 } },
        "function decl(arg) { var fn; if (arg) { fn = function expr() { }; } }",
        "if (test) { var foo; }",
        { code: "if (test) { let x = 1; }", options: ["both"], parserOptions: { ecmaVersion: 6 } },
        { code: "if (test) { const x = 1; }", options: ["both"], parserOptions: { ecmaVersion: 6 } },
        "function doSomething() { while (test) { var foo; } }",
        { code: "var foo;", options: ["both"] },
        { code: "var foo = 42;", options: ["both"] },
        { code: "function doSomething() { var foo; }", options: ["both"] },
        { code: "(function() { var foo; }());", options: ["both"] },
        { code: "foo(() => { function bar() { } });", parserOptions: { ecmaVersion: 6 } },
        { code: "var fn = () => {var foo;}", options: ["both"], parserOptions: { ecmaVersion: 6 } },
        {
            code: "var x = {doSomething() {var foo;}}",
            options: ["both"],
            parserOptions: { ecmaVersion: 6 }
        },
        {
            code: "export var foo;",
            options: ["both"],
            parserOptions: { sourceType: "module", ecmaVersion: 6 }
        },
        {
            code: "export function bar() {}",
            options: ["both"],
            parserOptions: { sourceType: "module", ecmaVersion: 6 }
        },
        {
            code: "export default function baz() {}",
            options: ["both"],
            parserOptions: { sourceType: "module", ecmaVersion: 6 }
        },
        {
            code: "exports.foo = () => {}",
            options: ["both"],
            parserOptions: { ecmaVersion: 6 }
        },
        {
            code: "exports.foo = function(){}",
            options: ["both"],
            parserOptions: { ecmaVersion: 6 }
        },
        {
            code: "module.exports = function foo(){}",
            options: ["both"],
            parserOptions: { ecmaVersion: 6 }
        }

    ],

    // Examples of code that should trigger the rule
    invalid: [
        {
            code: "if (test) { function doSomething() { } }",
            options: ["both"],
            errors: [{
                messageId: "moveDeclToRoot",
                data: {
                    type: "function",
                    body: "program"
                },
                type: "FunctionDeclaration"
            }]
        }, {
            code: "if (foo) var a; ",
            options: ["both"],
            errors: [{
                messageId: "moveDeclToRoot",
                data: {
                    type: "variable",
                    body: "program"
                },
                type: "VariableDeclaration"
            }]
        }, {
            code: "if (foo) /* some comments */ var a; ",
            options: ["both"],
            errors: [{
                messageId: "moveDeclToRoot",
                data: {
                    type: "variable",
                    body: "program"
                },
                type: "VariableDeclaration"
            }]
        }, {
            code: "if (foo){ function f(){ if(bar){ var a; } } }",
            options: ["both"],
            errors: [{
                messageId: "moveDeclToRoot",
                data: {
                    type: "function",
                    body: "program"
                },
                type: "FunctionDeclaration"
            }, {
                messageId: "moveDeclToRoot",
                data: {
                    type: "variable",
                    body: "function body"
                },
                type: "VariableDeclaration"
            }]
        }, {
            code: "if (foo) function f(){ if(bar) var a; } ",
            options: ["both"],
            errors: [{
                messageId: "moveDeclToRoot",
                data: {
                    type: "function",
                    body: "program"
                },
                type: "FunctionDeclaration"
            }, {
                messageId: "moveDeclToRoot",
                data: {
                    type: "variable",
                    body: "function body"
                },
                type: "VariableDeclaration"
            }]
        }, {
            code: "if (foo) { var fn = function(){} } ",
            options: ["both"],
            errors: [{
                messageId: "moveDeclToRoot",
                data: {
                    type: "variable",
                    body: "program"
                },
                type: "VariableDeclaration"
            }]
        },
        {
            code: "if (foo)  function f(){} ",
            options: ["both"],
            errors: [{
                messageId: "moveDeclToRoot",
                data: {
                    type: "function",
                    body: "program"
                },
                type: "FunctionDeclaration"
            }]
        },
        {
            code: "function bar() { if (foo) function f(){}; }",
            options: ["both"],
            errors: [{
                messageId: "moveDeclToRoot",
                data: {
                    type: "function",
                    body: "function body"
                },
                type: "FunctionDeclaration"
            }]
        },
        {
            code: "function bar() { if (foo) var a; }",
            options: ["both"],
            errors: [{
                messageId: "moveDeclToRoot",
                data: {
                    type: "variable",
                    body: "function body"
                },
                type: "VariableDeclaration"
            }]
        },
        {
            code: "if (foo){ var a; }",
            options: ["both"],
            errors: [{
                messageId: "moveDeclToRoot",
                data: {
                    type: "variable",
                    body: "program"
                },
                type: "VariableDeclaration"
            }]
        }, {
            code: "function doSomething() { do { function somethingElse() { } } while (test); }",
            errors: [{
                messageId: "moveDeclToRoot",
                data: {
                    type: "function",
                    body: "function body"
                },
                type: "FunctionDeclaration"
            }]
        }, {
            code: "(function() { if (test) { function doSomething() { } } }());",
            errors: [{
                messageId: "moveDeclToRoot",
                data: {
                    type: "function",
                    body: "function body"
                },
                type: "FunctionDeclaration"
            }]
        }, {
            code: "while (test) { var foo; }",
            options: ["both"],
            errors: [{
                messageId: "moveDeclToRoot",
                data: {
                    type: "variable",
                    body: "program"
                },
                type: "VariableDeclaration"
            }]
        }, {
            code: "function doSomething() { if (test) { var foo = 42; } }",
            options: ["both"],
            errors: [{
                messageId: "moveDeclToRoot",
                data: {
                    type: "variable",
                    body: "function body"
                },
                type: "VariableDeclaration"
            }]
        }, {
            code: "(function() { if (test) { var foo; } }());",
            options: ["both"],
            errors: [{
                messageId: "moveDeclToRoot",
                data: {
                    type: "variable",
                    body: "function body"
                },
                type: "VariableDeclaration"
            }]
        }
    ]
});