Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future major v6 notes #141

Open
animir opened this issue Oct 30, 2021 · 1 comment
Open

Future major v6 notes #141

animir opened this issue Oct 30, 2021 · 1 comment
Labels

Comments

@animir
Copy link
Owner

animir commented Oct 30, 2021

  1. blockDuration option should be undefined by default, so 0 can be used to block keys forever.
  2. Make sure RateLimiterQueue is created with default maxQueueSize even if it isn't set in options object, e.g. new RateLimiterQueue(memoryLimiter, {}) shouldn't result to maxQueueSize set to undefined.
  3. Support for points set to 0 and never limit in this case. It is useful for atomic counters.
@daniel-white
Copy link

consider adjusting the cb of the different implementations to return asynchronously if tableCreated: true - its not consistent w/ the other times cb is called.

another better design would be to have private constructors and a factory method that returns a promise

@animir animir changed the title Future major v3 notes Future major v4 notes Aug 29, 2023
@animir animir changed the title Future major v4 notes Future major v5 notes Feb 13, 2024
@animir animir changed the title Future major v5 notes Future major v6 notes Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants