Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement SQLite3 limiter class #29

Open
allouis opened this issue Jul 4, 2019 · 4 comments
Open

Implement SQLite3 limiter class #29

allouis opened this issue Jul 4, 2019 · 4 comments
Labels
feature good first issue Good for newcomers

Comments

@allouis
Copy link

allouis commented Jul 4, 2019

I've read the docs, and it seems you can pass through knex instances, but I didn't see if it supports SQLite3 - could you clarify please?
@animir animir added the question Further information is requested label Jul 4, 2019
@animir
Copy link
Owner

animir commented Jul 4, 2019 •
edited

This package does not support SQLite3 yet.

knex is supported but only for MySQL and PostgreSQL limiters now.

I believe, MySQL related limiter queries and approach is the most close to SQLite3 syntax, but should NOT work correctly with SQLite3.

I'd appreciate if you or somebody create SQLite3 specific limiter. It should not take long, since there is an example MySQL limiter.

@animir animir added good first issue Good for newcomers and removed question Further information is requested labels Jul 6, 2019
@animir animir changed the title Does this package support SQLite3? Implement SQLite3 limiter class Jul 6, 2019
@animir animir added the enhancement New feature or request label Sep 3, 2019
@animir animir added feature and removed enhancement New feature or request labels Oct 5, 2019
@animir
Copy link
Owner

animir commented Sep 8, 2021

Closing due to inactivity

@animir animir closed this as completed Sep 8, 2021
@animir animir reopened this Oct 6, 2021
@mihilmy
Copy link

mihilmy commented Mar 2, 2022

Any update on this? I'd be interested to contribute to this.

@animir
Copy link
Owner

animir commented Mar 3, 2022

@mihilmy Hey, nobody started contributing on this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@allouis @animir @mihilmy