Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Productionise WebView >= 77 check #15855

Closed
david-allison opened this issue Mar 11, 2024 · 5 comments · Fixed by #16550
Closed

Productionise WebView >= 77 check #15855

david-allison opened this issue Mar 11, 2024 · 5 comments · Fixed by #16550
Assignees
@neeldoshii
Labels
Enhancement Good First Issue!
Milestone
2.19 release

Comments

@david-allison
Copy link
Member

david-allison commented Mar 11, 2024 •
edited

It'd be worth having the dev-only check introduced in #14702 also explain to regular users how to upgrade.

Android 6 supports >= WebView 77, so a user should be able to upgrade

Originally posted by @david-allison in #15847 (comment)

EDIT: Please also include a guide to fix the WebView if the package is incorrect: #15847 (comment)
@david-allison david-allison changed the title Productionise WebView > 77 check Productionise WebView >= 77 check Mar 11, 2024
@aayush-tripathi
Copy link
Contributor

Hey! Can I work on this?

@aayush-tripathi
Copy link
Contributor

Hello again. I have been working on this issue and have come up with the following Dialog Box containing a link to the Google Play Store.
Screenshot 2024-03-13 024444
I want to confirm if I have approached this correctly. Thanks!

@david-allison
Copy link
Member Author

david-allison commented Mar 12, 2024 •
edited

Looks like a good UI! We'll need to work on the strings, but that can be done in the PR

  • Link to a wiki page which we can update later
  • See if you can detect if the old package is installed, as this warrants different instructions:

Anki-Android/AnkiDroid/src/main/java/com/ichi2/utils/WebViewUtils.kt

Lines 39 to 40 in 818a813

return getPackage("com.google.android.webview")
?: getPackage("com.android.webview") // com.android.webview is used on API 24

This was referenced Mar 13, 2024
Closed
Closed
@neeldoshii
Copy link
Contributor

Can i get assigned to this as the above PR is saying Needs a new dev?

@david-allison
Copy link
Member Author

@neeldoshii done, please use the PR as it's REALLY close + please be sure you're using git cherry pick to give them credit

@RobozinhoD RobozinhoD mentioned this issue Jun 4, 2024
Merged
5 tasks
@github-actions github-actions bot added this to the 2.19 release milestone Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neeldoshii neeldoshii

Labels
Enhancement Good First Issue!
Projects
None yet
Milestone
2.19 release
3 participants
@neeldoshii @david-allison @aayush-tripathi