Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: AnkiDroid to use Flag names like Anki #16222

Closed
4 of 5 tasks
criticalAY opened this issue Apr 19, 2024 · 5 comments · Fixed by #16242
Closed
4 of 5 tasks

[BUG]: AnkiDroid to use Flag names like Anki #16222

criticalAY opened this issue Apr 19, 2024 · 5 comments · Fixed by #16242
Assignees
@Giyutomioka-SS
Labels
Anki Ecosystem Compatibility Blocked by dependency Currently blocked by some other dependent / related change Good First Issue!
Milestone
2.19 release

Comments

@criticalAY
Copy link
Contributor

Checked for duplicates?

  • This issue is not a duplicate

Does it also happen in the desktop version?

  • This bug does not occur in the latest version of Anki

What are the steps to reproduce this bug?

While working on #16218 I noticed that the flag names used in AnkiDroid doesn't match that of Anki,

Expected behaviour

Same names as Anki

Actual behaviour

Different string values

Debug info

Not needed

(Optional) Anything else you want to share?

No response

Research

  • I am reporting a bug specific to AnkiDroid (Android app)
  • I have checked the manual and the FAQ and could not find a solution to my issue
  • (Optional) I have confirmed the issue is not resolved in the latest alpha release (instructions)
@david-allison david-allison added Anki Ecosystem Compatibility Good First Issue! Blocked by dependency Currently blocked by some other dependent / related change and removed Bug Needs Triage labels Apr 20, 2024
@david-allison
Copy link
Member

david-allison commented Apr 20, 2024 •
edited

The relevant strings come from com.ichi2.anki.CollectionManager.TR:

TR.actionsFlagBlue() etc...

@criticalAY

This comment was marked as outdated.

Sign in to view
@Giyutomioka-SS
Copy link
Contributor

Working on this!

@david-allison
Copy link
Member

@Giyutomioka-SS This may need to be reworked after #16218 goes in

@criticalAY
Copy link
Contributor Author

@Giyutomioka-SS Can be worked on now, no longer blocked

@Giyutomioka-SS Giyutomioka-SS mentioned this issue Apr 21, 2024
Merged
5 tasks
@github-actions github-actions bot added this to the 2.19 release milestone May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Giyutomioka-SS Giyutomioka-SS

Labels
Anki Ecosystem Compatibility Blocked by dependency Currently blocked by some other dependent / related change Good First Issue!
Projects
None yet
Milestone
2.19 release
Development

Successfully merging a pull request may close this issue.

AnkiDroid to use flag names like anki Giyutomioka-SS/Anki-Android
3 participants
@criticalAY @david-allison @Giyutomioka-SS