Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support renaming flags #16205

Open
david-allison opened this issue Apr 18, 2024 · 9 comments · May be fixed by #16244
Open

Support renaming flags #16205

david-allison opened this issue Apr 18, 2024 · 9 comments · May be fixed by #16244

Comments

@david-allison
Copy link
Member

@criticalAY
Copy link
Contributor

Taking it up next

@david-allison
Copy link
Member Author

@criticalAY What's the rough plan for where this functionality exists?

@criticalAY
Copy link
Contributor

I am thinking to put the rename setting in browser menu as Anki does here
image

So, it would be somewhat consistent, we can give an option - Rename flags and click the submenu item i.e. flags should show a rename dialog where user can rename the flag or cancel it.

@david-allison
Copy link
Member Author

david-allison commented Apr 20, 2024

Possibly long-press a flag name in the browser for now?

@criticalAY
Copy link
Contributor

criticalAY commented Apr 20, 2024

Thought of it, if it would be less complex and clean then will go with this only

@lukstbit
Copy link
Contributor

The vast majority of users will not use this feature so I don't think there should be an entry for this in the CardBrowser menu. As an alternative maybe we could add it in the CardBrowser's Options menu dialog.

@criticalAY Before taking on other issues please also consider working on the issues you already have open and where there are changes requests.

@criticalAY
Copy link
Contributor

I don't have a pending queue ig ? I'm mostly caught up which issue are you talking about though?

@david-allison
Copy link
Member Author

You have a few open PRs: https://github.com/ankidroid/Anki-Android/pulls/criticalAY

@criticalAY
Copy link
Contributor

I just resolved conflicts, and saw the comments left by luksbit on IO related PR which I missed the notification of, thanks!

@criticalAY criticalAY linked a pull request Apr 22, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants