Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue 3 support? #32

Closed
swaprenge opened this issue Oct 15, 2020 · 13 comments
Closed

Vue 3 support? #32

swaprenge opened this issue Oct 15, 2020 · 13 comments
Assignees
Milestone

Comments

@swaprenge
Copy link

Tell about your platform

  • Vue.js version : ^3.0.0
  • Browser name and version : Chrome|Firefox|Safari x.x.x
  • This package version : 0.5.4

Current behavior
This plugin works fine with vue version < 3.0.0

Expected behavior
Upgraded to Vue3 and Vue.extend is not supported in Vue3.
Also, the way to use the plugin in Vue3 is changed.

Minimal reproduction of the problem with instructions

  • Upgrade to Vue version 3.0.0.

@ankurk91 Can you please help me with this?

@ankurk91 ankurk91 self-assigned this Oct 15, 2020
@ankurk91 ankurk91 pinned this issue Oct 15, 2020
@ankurk91 ankurk91 changed the title Add Support to Vue3 Vue 3 support? Oct 22, 2020
@italocassio

This comment has been minimized.

@Alehandro231

This comment has been minimized.

@ankurk91
Copy link
Owner

Unless I get enough time to upgrade this package for Vue 3.x, One can opt-in to go for
https://github.com/Maronato/vue-toastification/tree/next

@ankurk91
Copy link
Owner

ankurk91 commented Jun 13, 2021

Made some progress on next branch

  • Update docs
  • Test case
  • Type definitions
  • Change log
  • Upgrade guide
  • New JS Fiddle link

@bhavinjr
Copy link

@ankurk91 Do we have a toast transition option?
if not then can we go with it to the next branch?

@ankurk91
Copy link
Owner

@bhavinjr
Yes, we have it already

@bhavinjr
Copy link

@ankurk91 That's great.
can you please give the all transition option/effect. as of now, I didn't find it in the document

Vue.$toast.open({
    message: 'Something went wrong!',
    type: 'error',
    transition: 'bounce' // all transition effect
});

@ankurk91
Copy link
Owner

ankurk91 commented Jun 21, 2021

I meant it is there but you can not customize it

:enter-active-class="transition.enter"

@rojadesign
Copy link

@ankurk91 Do you have a specific date when you will publish the Vue 3 version? I ask because I see you have a next-branch. We need to evaluate if we can stick to this beautiful plugin or look for alternatives because we have some time pressure. Thank you so much for all your work!

@ankurk91
Copy link
Owner

ankurk91 commented Jul 13, 2021

Hey, thanks for reaching out.

I can publish the beta tomorrow , my morning.

@ankurk91
Copy link
Owner

ankurk91 commented Jul 14, 2021

@rojadesign

Version 2.0 beta has been published.

npm i vue-toast-notification@2.0.0

@bhavinjr
Copy link

bhavinjr commented Jul 14, 2021

I meant it is there but you can not customize it

:enter-active-class="transition.enter"

@ankurk91 Can you plan for this feature in the next publish if possible?

@ankurk91
Copy link
Owner

I can not promise.

@ankurk91 ankurk91 added this to the 2.00 milestone Aug 1, 2021
Repository owner locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants