Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alternative country names #35

Open
dmythro opened this issue Jan 7, 2019 · 14 comments
Open

Add alternative country names #35

dmythro opened this issue Jan 7, 2019 · 14 comments
Labels

Comments

@dmythro
Copy link
Member

dmythro commented Jan 7, 2019

Let's work on a discussion started in #31: some countries have the main and alternative names and it's nice to cover this information in a proper way.

List, based on comments below:

  • Belarus, Republic of Belarus
  • Belgium, Kingdom of Belgium; Native names (in local official languages):
    • Belgique, Royaume de Belgique (French)
    • België, Koninkrijk België (Dutch)
    • Belgien, Königreich Belgien (German)
  • Cyprus, Republic of Cyprus
    • Κύπρος, Κυπριακή Δημοκρατία (Greek)
    • Kıbrıs, Kıbrıs Cumhuriyeti (Turkish)
  • Myanmar, Burma
  • Poland, Republic of Poland
  • Russia, Russian Federation
  • United Kingdom, United Kingdom of Great Britain and Northern Ireland, Britain, UK
  • United States of America, United States, America, US
@jbelien
Copy link

jbelien commented Jan 7, 2019

  • Myanmar ; Burma
  • Belgium ; Kingdom of Belgium
    Native names (in local official languages):
    • Belgique ; Royaume de Belgique (French)
    • België ; Koninkrijk België (Dutch)
    • Belgien ; Königreich Belgien (German)

@dmythro
Copy link
Member Author

dmythro commented Jan 7, 2019

Native name is now a string. To keep the support, we should use a comma-separated string for now (and probably make it array in future releases): "Belgique, België, Belgien". By the way, why now it is only one? Is there main locale among those three?

@jbelien
Copy link

jbelien commented Jan 8, 2019

I'm okay with comma-separated string 👍

No idea why at the moment there is only the Dutch name but that's just well ... wrong. The 3 official languages are at the same level :)

@dmythro
Copy link
Member Author

dmythro commented Jan 8, 2019

Looks like a lot of countries have official names which differ from common usage :) Bad news is: should probably check each country at least on Wikipedia to do the job.

Probably, it also may make sense to have official name property if it differs from the main name. And alternative as array or comma-separated string.

Here are some I could remember and checked:

  • Belarus, Republic of Belarus
  • Cyprus, Republic of Cyprus
  • Poland, Republic of Poland
  • Russia, Russian Federation
  • United Kingdom, United Kingdom of Great Britain and Northern Ireland, Britain, UK
  • United States of America, United States, America, US

@dmythro
Copy link
Member Author

dmythro commented Jan 8, 2019

Updating the list in the description, in alphabetical order.

@jbelien
Copy link

jbelien commented Jan 21, 2019

First draft of the list seems good to me ! 👍

@dmythro
Copy link
Member Author

dmythro commented Jan 21, 2019

Maybe, we could add native names in certain languages like "native_fr": "Belgique, Royaume de Belgique"? And original "native" to contain all of them concatenated: "native": "Belgique, Royaume de Belgique, België, Koninkrijk België ...".

@jbelien
Copy link

jbelien commented Jan 21, 2019

Oh sure, if we could include a language "tag" that would be even better ! 🎉

I would maybe go for "native": {"fr":"Belgique", ...} than "native_fr": "Belgique"

@dmythro
Copy link
Member Author

dmythro commented Jan 21, 2019

There's a cave-eat for CSV, SQL etc. I try to have simple structures, which are easy to use and describe with TS.

But for the next major version bump should probably re-think the module structure to use all advantages of JS and easily convert to other simpler formats. Have more JS code (getters, converters etc).

@jbelien
Copy link

jbelien commented Jan 21, 2019

There's a cave-eat for CSV, SQL etc. I try to have simple structures, which are easy to use and describe with TS.

That makes sense 👍

@dmythro dmythro self-assigned this Jan 22, 2019
@dmythro dmythro added this to To do in v2.5.0 Jan 22, 2019
@ekleel
Copy link

ekleel commented Jul 29, 2019

Here two additional countries to consider

  • Kingdom of Saudi Arabia, Saudi Arabia

    • Full name in Arabic: المملكة العربية السعودية
    • Short name in Arabic: السعودية
  • United Arab Emirates

    • Full name in Arabic: الإمارات العربية المتحدة
    • Short name in Arabic: الإمارات

@dmythro
Copy link
Member Author

dmythro commented Jul 29, 2019

Thanks! I think will share updates on this later this month, so everyone will have ability to validate/contribute with actual data.

@jbelien
Copy link

jbelien commented Oct 19, 2019

Any update on this ?

@dmythro dmythro removed this from To do in v2.5.0 Oct 29, 2019
@dmythro dmythro added this to To do in Board Classic Oct 29, 2019
@dmythro dmythro moved this from To do to In progress in Board Classic Oct 31, 2019
@seanonthenet
Copy link

+1

@dmythro dmythro moved this from In progress to To do in Board Classic May 8, 2023
@dmythro dmythro removed their assignment May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Board Classic
  
To do
Development

No branches or pull requests

4 participants