Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saudi Arabia native name is incorrect #43

Open
ekleel opened this issue Jul 29, 2019 · 4 comments
Open

Saudi Arabia native name is incorrect #43

ekleel opened this issue Jul 29, 2019 · 4 comments

Comments

@ekleel
Copy link

ekleel commented Jul 29, 2019

Hello, and thank you for this great list.

I just noticed that the native name of Saudi Arabia is missing a word. In the countries' list it's العربية السعودية, but it should be المملكة العربية السعودية. Or you can opt to use the single-word version which is السعودية. Both are valid.

Thanks again.

  • Kingdom of Saudi Arabia, Saudi Arabia
    • Full name in Arabic: المملكة العربية السعودية
    • Short name in Arabic: السعودية
@dmythro dmythro added the update label Aug 2, 2019
@dmythro dmythro added this to To do in v2.5.0 Oct 29, 2019
@dmythro dmythro moved this from To do to In progress in v2.5.0 Oct 30, 2019
@dmythro
Copy link
Member

dmythro commented Oct 30, 2019

It's still "Saudi Arabia" on all the maps, so not really sure, to be honest, which versions should appear here in this case. But at least will add other versions with a new feature — alternative names, so all names can be found here.

Also, can be specified as "official", "display" and "native" names.

The question is up for discussion, please share your opinion.

@dmythro dmythro removed this from In progress in v2.5.0 Oct 30, 2019
@dmythro dmythro added this to To do in Board Classic Oct 30, 2019
@ekleel
Copy link
Author

ekleel commented Oct 30, 2019

Yes, Saudi Arabia is correct, but the issue here is with the native Arabic variant, not the English one. In Arabic, it's المملكة العربية السعودية.

Although it would be great to have an option for how the country name is formated. As in display: United States or official: United States of America.

@dmythro
Copy link
Member

dmythro commented Oct 31, 2019

But المملكة العربية السعودية is literally Kingdom of Saudi Arabia not Saudi Arabia, isn't it?
At least we need to have consistency between the name and translation, I think.

I have a thought that in v3.0 the name will be how it's used on maps, but in addition there will be optional field with officialName: "" if it differs, and alternateNames: [] if there are any, to have ability of a full control over displayed data by project using this library.

@ekleel
Copy link
Author

ekleel commented Jan 21, 2020

That sounds great. I'd love that!

And yes you're right. It may have been a literal translation from Saudi Arabia, but this format is only valid in English and is short for Kingdom of Saudi Arabia.

But to get back to the main issue here, which does not require any new features and is a simple edit to the Arabic phrasing. What I'm suggesting is that the Arabic phrase used in this library العربية السعودية is incorrect and no one calls the country this way. It should be replaced by المملكة العربية السعودية.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Board Classic
  
To do
Development

No branches or pull requests

2 participants