{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":694699784,"defaultBranch":"master","name":"PHP_CodeSniffer","ownerLogin":"anomiex","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2023-09-21T14:14:06.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/1030580?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1701461007.0","currentOid":""},"activityList":{"items":[{"before":"245efc556343c60a04cb57ad5c59ae04d1fd9a46","after":"0ba5736e423c8ba3dafe3ed382aa58b91cc5c315","ref":"refs/heads/fix/line-wrapping-bugs","pushedAt":"2023-12-11T00:28:01.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"},"commit":{"message":"Report Full: iterate on line wrapping bug fix [3]\n\nDon't hard code the color code length to prevent this breaking on potential future changes.\n\nCo-authored-by: Brad Jorsch ","shortMessageHtmlLink":"Report Full: iterate on line wrapping bug fix [3]"}},{"before":"b9dd7db37a5f94469eec817bee8baa4ec3f6959d","after":"245efc556343c60a04cb57ad5c59ae04d1fd9a46","ref":"refs/heads/fix/line-wrapping-bugs","pushedAt":"2023-12-11T00:25:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"},"commit":{"message":"Report Full: iterate on line wrapping bug fix [3]\n\nDon't hard code the color code length to prevent this breaking on potential future changes.\n\nCo-authored-by: Brad Jorsch ","shortMessageHtmlLink":"Report Full: iterate on line wrapping bug fix [3]"}},{"before":"3577799f9d7300c462205d07563f6f0429a8e2f0","after":"b9dd7db37a5f94469eec817bee8baa4ec3f6959d","ref":"refs/heads/fix/line-wrapping-bugs","pushedAt":"2023-12-11T00:15:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"},"commit":{"message":"Report Full: iterate on line wrapping bug fix [2]\n\nPrevent inconsistency in handling of single-line vs multi-line length calculation.\n\nCo-authored-by: Brad Jorsch ","shortMessageHtmlLink":"Report Full: iterate on line wrapping bug fix [2]"}},{"before":"5ea74470ce91303d1bf4e183809f2d7139409e86","after":"7338e5ad8adaaa62eb3ff5b2cdcaaef85e7850b3","ref":"refs/heads/fix/ignore-list-handling","pushedAt":"2023-12-10T22:40:14.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"anomiex","name":"Brad Jorsch","path":"/anomiex","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1030580?s=80&v=4"},"commit":{"message":"Make phpstan happy","shortMessageHtmlLink":"Make phpstan happy"}},{"before":"0febbfbc9f61555c00c7c1084270b2b2c90a6f8c","after":"3577799f9d7300c462205d07563f6f0429a8e2f0","ref":"refs/heads/fix/line-wrapping-bugs","pushedAt":"2023-12-10T19:48:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"},"commit":{"message":"Report Full: iterate on line wrapping bug fix\n\nThis commit takes the fix one step further by adding the padding only after the message has been word-wrapped.\nIncludes correct handling of padding for multi-line error messages.\n\nIt then takes the last line of the resulting message and detemines in isolation whether the source code suffix can fit on that line or needs to be placed on a new line.","shortMessageHtmlLink":"Report Full: iterate on line wrapping bug fix"}},{"before":"c0300cc0090aa778aeded8962415811104d794e1","after":"0febbfbc9f61555c00c7c1084270b2b2c90a6f8c","ref":"refs/heads/fix/line-wrapping-bugs","pushedAt":"2023-12-10T18:59:15.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"anomiex","name":"Brad Jorsch","path":"/anomiex","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1030580?s=80&v=4"},"commit":{"message":"Fix two line wrapping bugs in default report formatter\n\nThe first is that the ANSI escape codes applied to bold the message when\n`-s` is used were not being taken into account when wrapping the lines\nfor width, causing some lines to be wrapped unnecessarily.\n\nThe second is that when lines were wrapped in the middle of a long\nmessage, the `|` characters making up the table were being bolded along\nwith the message.","shortMessageHtmlLink":"Fix two line wrapping bugs in default report formatter"}},{"before":"ade94ce4a397389d8108d65b5937f24c9030582b","after":"5ea74470ce91303d1bf4e183809f2d7139409e86","ref":"refs/heads/fix/ignore-list-handling","pushedAt":"2023-12-04T17:50:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"anomiex","name":"Brad Jorsch","path":"/anomiex","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1030580?s=80&v=4"},"commit":{"message":"Make phpstan happy","shortMessageHtmlLink":"Make phpstan happy"}},{"before":"5b83e1fe01b3f479c2bea18b1f62046e5493f2bb","after":"c0300cc0090aa778aeded8962415811104d794e1","ref":"refs/heads/fix/line-wrapping-bugs","pushedAt":"2023-12-04T16:27:37.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"anomiex","name":"Brad Jorsch","path":"/anomiex","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1030580?s=80&v=4"},"commit":{"message":"Fix two line wrapping bugs in default report formatter\n\nThe first is that the ANSI escape codes applied to bold the message when\n`-s` is used were not being taken into account when wrapping the lines\nfor width, causing some lines to be wrapped unnecessarily.\n\nThe second is that when lines were wrapped in the middle of a long\nmessage, the `|` characters making up the table were being bolded along\nwith the message.","shortMessageHtmlLink":"Fix two line wrapping bugs in default report formatter"}},{"before":"62ac505b7ec95200a13fb08066575dee19a818ba","after":"ade94ce4a397389d8108d65b5937f24c9030582b","ref":"refs/heads/fix/ignore-list-handling","pushedAt":"2023-12-04T16:17:22.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"anomiex","name":"Brad Jorsch","path":"/anomiex","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1030580?s=80&v=4"},"commit":{"message":"Improve handling of disable/enable/ignore directives\n\nThe current method, listing codes to disable and a list of exceptions to\nthat list, still has trouble with some cases. For example, disabling a\nstandard, re-enabling a category within that standard, then ignoring or\ndisabling a sniff within that category cannot be handled. We'd need a\nlist of exceptions to the exceptions, and possibly a list of exceptions\nto that list too, and figuring out how to keep those lists up to date as\nnew directives are encountered could prove to be confusing.\n\nSince the standard→category→sniff→code hierarchy is supposed to be\nthought of as a tree, let's store the ignore list that way instead.\nManipulating the branches of the tree is straightforward no matter what\ndirectives are encountered.\n\nIn this implementation I've favored speed over space: there are cases\nwhere we could prune a subtree that would evaluate to \"ignore\" or \"don't\nignore\" for any possible input, but detecting that doesn't seem worth\nthe time when it's not likely there will be so many enable or disable\ndirectives that the wasted space will be a problem.\n\nFixes #111","shortMessageHtmlLink":"Improve handling of disable/enable/ignore directives"}},{"before":"7763e2e1f773cb0615ed8afa133189fc804f583d","after":"c248a92ae11e79325a1509a8eb604004d8d9cd83","ref":"refs/heads/master","pushedAt":"2023-12-04T16:16:54.000Z","pushType":"push","commitsCount":129,"pusher":{"login":"anomiex","name":"Brad Jorsch","path":"/anomiex","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1030580?s=80&v=4"},"commit":{"message":"Changelog for #121","shortMessageHtmlLink":"Changelog for PHPCSStandards#121"}},{"before":"b34da98f48994c1f04d25b20d6126f34a3e4f16a","after":null,"ref":"refs/heads/fix/ignore-list-handling-2","pushedAt":"2023-12-01T20:03:27.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"anomiex","name":"Brad Jorsch","path":"/anomiex","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1030580?s=80&v=4"}},{"before":null,"after":"b34da98f48994c1f04d25b20d6126f34a3e4f16a","ref":"refs/heads/fix/ignore-list-handling-2","pushedAt":"2023-12-01T20:02:09.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"anomiex","name":"Brad Jorsch","path":"/anomiex","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1030580?s=80&v=4"}},{"before":null,"after":"5b83e1fe01b3f479c2bea18b1f62046e5493f2bb","ref":"refs/heads/fix/line-wrapping-bugs","pushedAt":"2023-11-14T21:55:41.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"anomiex","name":"Brad Jorsch","path":"/anomiex","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1030580?s=80&v=4"},"commit":{"message":"Fix two line wrapping bugs in default report formatter\n\nThe first is that the ANSI escape codes applied to bold the message when\n`-s` is used were not being taken into account when wrapping the lines\nfor width, causing some lines to be wrapped unnecessarily.\n\nThe second is that when lines were wrapped in the middle of a long\nmessage, the `|` characters making up the table were being bolded along\nwith the message.","shortMessageHtmlLink":"Fix two line wrapping bugs in default report formatter"}},{"before":"7566b4d89de1d08d2a8ad85910507d6633a35d28","after":"7763e2e1f773cb0615ed8afa133189fc804f583d","ref":"refs/heads/master","pushedAt":"2023-11-14T21:47:27.000Z","pushType":"push","commitsCount":7,"pusher":{"login":"anomiex","name":"Brad Jorsch","path":"/anomiex","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1030580?s=80&v=4"},"commit":{"message":"Changelog for #3908","shortMessageHtmlLink":"Changelog for #3908"}},{"before":"299eb62bcf53595700ac3f2a854f9223c32357c4","after":"62ac505b7ec95200a13fb08066575dee19a818ba","ref":"refs/heads/fix/ignore-list-handling","pushedAt":"2023-09-21T19:30:34.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"anomiex","name":"Brad Jorsch","path":"/anomiex","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1030580?s=80&v=4"},"commit":{"message":"Improve handling of disable/enable/ignore directives\n\nThe current method, listing codes to disable and a list of exceptions to\nthat list, still has trouble with some cases. For example, disabling a\nstandard, re-enabling a category within that standard, then ignoring or\ndisabling a sniff within that category cannot be handled. We'd need a\nlist of exceptions to the exceptions, and possibly a list of exceptions\nto that list too, and figuring out how to keep those lists up to date as\nnew directives are encountered could prove to be confusing.\n\nSince the standard→category→sniff→code hierarchy is supposed to be\nthought of as a tree, let's store the ignore list that way instead.\nManipulating the branches of the tree is straightforward no matter what\ndirectives are encountered.\n\nIn this implementation I've favored speed over space: there are cases\nwhere we could prune a subtree that would evaluate to \"ignore\" or \"don't\nignore\" for any possible input, but detecting that doesn't seem worth\nthe time when it's not likely there will be so many enable or disable\ndirectives that the wasted space will be a problem.\n\nFixes #3889","shortMessageHtmlLink":"Improve handling of disable/enable/ignore directives"}},{"before":null,"after":"299eb62bcf53595700ac3f2a854f9223c32357c4","ref":"refs/heads/fix/ignore-list-handling","pushedAt":"2023-09-21T19:21:36.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"anomiex","name":"Brad Jorsch","path":"/anomiex","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1030580?s=80&v=4"},"commit":{"message":"Improve handling of disable/enable/ignore directives\n\nThe current method, listing codes to disable and a list of exceptions to\nthat list, still has trouble with some cases. For example, disabling a\nstandard, re-enabling a category within that standard, then ignoring or\ndisabling a sniff within that category cannot be handled. We'd need a\nlist of exceptions to the exceptions, and possibly a list of exceptions\nto that list too, and figuring out how to keep those lists up to date as\nnew directives are encountered could prove to be confusing.\n\nSince the standard→category→sniff→code hierarchy is supposed to be\nthought of as a tree, let's store the ignore list that way instead.\nManipulating the branches of the tree is straightforward no matter what\ndirectives are encountered.\n\nIn this implementation I've favored speed over space: there are cases\nwhere we could prune a subtree that would evaluate to \"ignore\" or \"don't\nignore\" for any possible input, but detecting that doesn't seem worth\nthe time when it's not likely there will be so many enable or disable\ndirectives that the wasted space will be a problem.\n\nFixes #3889","shortMessageHtmlLink":"Improve handling of disable/enable/ignore directives"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAADxr3E3QA","startCursor":null,"endCursor":null}},"title":"Activity · anomiex/PHP_CodeSniffer"}