From 12bf9b8da3d4bb76b74d6dca376d7f7a3c3d4fce Mon Sep 17 00:00:00 2001 From: Yagiz Nizipli Date: Sat, 19 Nov 2022 15:13:36 -0500 Subject: [PATCH] lib: improve transferable abort controller exec PR-URL: https://github.com/nodejs/node/pull/45525 Reviewed-By: Matteo Collina Reviewed-By: Antoine du Hamel --- lib/internal/abort_controller.js | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/lib/internal/abort_controller.js b/lib/internal/abort_controller.js index 49419736f65bf6..3c72a91f763c93 100644 --- a/lib/internal/abort_controller.js +++ b/lib/internal/abort_controller.js @@ -318,19 +318,13 @@ function validateAbortController(obj) { } class AbortController { - #signal; - - constructor() { - this[kSignal] = createAbortSignal(); - } - /** * @type {AbortSignal} */ get signal() { validateAbortController(this); - this.#signal ??= createAbortSignal(); - return this.#signal; + this[kSignal] ??= createAbortSignal(); + return this[kSignal]; } /** @@ -338,7 +332,7 @@ class AbortController { */ abort(reason = new DOMException('This operation was aborted', 'AbortError')) { validateAbortController(this); - abortSignal(this.#signal ??= createAbortSignal(), reason); + abortSignal(this[kSignal] ??= createAbortSignal(), reason); } [customInspectSymbol](depth, options) { @@ -349,7 +343,7 @@ class AbortController { static [kMakeTransferable]() { const controller = new AbortController(); - controller[kSignal] = transferableAbortSignal(controller[kSignal]); + controller[kSignal] = createAbortSignal({ transferable: true }); return controller; } }