Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support openssl_crl much like openssl_certificate #53789

Closed
fawaf opened this issue Mar 14, 2019 · 24 comments · May be fixed by ansible-collections/community.crypto#30
Closed

support openssl_crl much like openssl_certificate #53789

fawaf opened this issue Mar 14, 2019 · 24 comments · May be fixed by ansible-collections/community.crypto#30
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bot_closed collection:community.crypto collection Related to Ansible Collections work crypto Crypto community (ACME, openssl, letsencrypt) feature This issue/PR relates to a feature request. has_pr This issue has an associated PR. module This issue/PR relates to a module. needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md support:community This issue/PR relates to code supported by the Ansible community.

Comments

@fawaf
Copy link
Contributor

fawaf commented Mar 14, 2019

SUMMARY

support openssl_crl much like openssl_certificate

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

new module name: openssl_crl

ADDITIONAL INFORMATION

it would be used in very much the same way as the openssl_certificate module just that it would be specific for crl. crl has some attributes that a cert does not have (e.g. lastupdated, nextupdate, etc.)

openssl_certificate:
    path: /etc/ssl/example.com.crl
    provider: assertonly
    issuer:
      O: Let's Encrypt
    has_expired: False
    next_update: 39992711
@ansibot
Copy link
Contributor

ansibot commented Mar 14, 2019

Files identified in the description:
None

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Mar 14, 2019
@sivel
Copy link
Member

sivel commented Apr 2, 2019

!component =lib/ansible/modules/crypto/openssl_crl.py

@ansibot
Copy link
Contributor

ansibot commented Apr 2, 2019

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Apr 2, 2019

@ansibot ansibot added crypto Crypto community (ACME, openssl, letsencrypt) module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. and removed needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Apr 2, 2019
@felixfontein
Copy link
Contributor

Are you interested in getting information on CRLs (or validate conditions on these), as your example shows, or also to generate / sign CRLs?

@fawaf
Copy link
Contributor Author

fawaf commented Apr 3, 2019

primarily the former, but having both would be great as well.

@ansibot ansibot added support:core This issue/PR relates to code supported by the Ansible Engineering Team. and removed module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. labels Apr 11, 2019
@ansibot ansibot added module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. and removed support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Apr 19, 2019
@jackivanov
Copy link

CRL is actually a must have module if we want to manage the complete chain by Ansible. I would like to see this implemented as well

@felixfontein
Copy link
Contributor

If you could be more specific and say what exactly you want such a module to do, that would help a lot. I've never needed CRLs, so in case I ever work on such a module, I would like to know what people want to use it for :)

(Also, if someone wants to contribute such a module: feel free! I'm not sure whether I'll work on that anytime soon, or at all...)

@jackivanov
Copy link

Well, to revoke the certificates and prevent users from being able to access the system. eg: a vpn system, the operator may want to add and remove users, and if the authentication works via pubkeys, the crl is the only way to remove users.

@felixfontein
Copy link
Contributor

So you want to be able to create / update CRLs? If yes, how? Or to verify CRLs? Check whether certificates appear in the CRL?

@jackivanov
Copy link

To create and update

@fawaf
Copy link
Contributor Author

fawaf commented Jul 15, 2019

in my case, obtain data from the crl (similar to a crt). e.g. lastupdate, nextupdate, issue, etc.

@felixfontein felixfontein added the waiting_on_contributor This would be accepted but there are no plans to actively work on it. label Aug 11, 2019
@ansibot ansibot added waiting_on_contributor This would be accepted but there are no plans to actively work on it. and removed waiting_on_contributor This would be accepted but there are no plans to actively work on it. labels Aug 11, 2019
@felixfontein
Copy link
Contributor

I started creating a WIP PR for a x509_crl module in #63435, which allows creation / updating of CRLs. Once that's done, adding a corresponding _info module (for returning information on a CRL) is trivial. Please take a look whether this is what you are looking for.

@ansibot ansibot added the has_pr This issue has an associated PR. label Oct 13, 2019
@felixfontein
Copy link
Contributor

@gnowxilef @jackivanov since you explicitly asked for a openssl_crl module, could you please take a look at the new module in #63435? Any kind of feedback would be really helpful!

@felixfontein
Copy link
Contributor

@gnowxilef @jackivanov ping

@fawaf
Copy link
Contributor Author

fawaf commented Jan 13, 2020

sorry about that, haven't had a chance to use it yet, but the code looks fine.

@felixfontein
Copy link
Contributor

felixfontein commented Jan 13, 2020

@gnowxilef thanks for taking a look! Did you also look at the module interface? Does it provide what you need / think is needed? (For creating/updating CRLs, that is.)

@fawaf
Copy link
Contributor Author

fawaf commented Jan 14, 2020

ah, the code looks to only create/update crls it seems? i would also like it to be able to retrieve information about the crl itself, such as nextupdate, lastupdate, digest, etc.

@felixfontein
Copy link
Contributor

Yes. Adding a x509_crl_info module would be the next step after x509_crl is merged.

@fawaf
Copy link
Contributor Author

fawaf commented Jan 31, 2020

can this be merged yet?

@felixfontein
Copy link
Contributor

@fawaf as soon as it gets a proper review.

@felixfontein
Copy link
Contributor

I began with a x509_crl_info module in #67539.

@felixfontein
Copy link
Contributor

That module is now also merged. During developing it, we decided to not add revocation query support to that module, but add another module openssl_certificate_revocation or so which allows to query various revocation sources (i.e. CRL, OCSP). I'll look into developing that once stuff has been moved to collections (the moving process starts next week).

@ansibot
Copy link
Contributor

ansibot commented Aug 16, 2020

Thank you very much for your interest in Ansible. Ansible has migrated much of the content into separate repositories to allow for more rapid, independent development. We are closing this issue/PR because this content has been moved to one or more collection repositories.

For further information, please see:
https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md

@ansibot ansibot closed this as completed Aug 16, 2020
@ansible ansible locked and limited conversation to collaborators Sep 13, 2020
@sivel sivel removed the waiting_on_contributor This would be accepted but there are no plans to actively work on it. label Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bot_closed collection:community.crypto collection Related to Ansible Collections work crypto Crypto community (ACME, openssl, letsencrypt) feature This issue/PR relates to a feature request. has_pr This issue has an associated PR. module This issue/PR relates to a module. needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants