Prevent rule 208 matche in nomaches example #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file nomatches.yml started triggering a finding on 4.3.0 due to missing file permissions.
|
Have you tested this with 4.3.5? 4.3.0 has been edited many time surrounding rule 208. |
|
@greg-hellings yes, 4.3.5 triggers it. |
ssbarnea
changed the title
ssbarnea
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
While packaging the latest release on Debian I noticed one of our CI tests started failing due to the example nomatches.yml throwing a finding.
It's a small issue that got triggered on 4.3.0 due to #949.
This change merely sets
modefor the file.commit description:
The file nomatches.yml started triggering a finding on 4.3.0 due to
missing file permissions.