Add optional rule to check for loop var prefix #1303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
force-pushed
the
0/mock-roles
branch
5 times, most recently
from
bf987eb
to
9d9c63e
Compare
ssbarnea
force-pushed
the
0/mock-roles
branch
from
0fa08ab
to
64ec90c
Compare
ssbarnea
changed the title
ssbarnea
force-pushed
the
0/mock-roles
branch
4 times, most recently
from
78394a7
to
531f670
Compare
Based on original custom rule written by Albin Vass on https://opendev.org/zuul/zuul-jobs/blame/branch/master/.rules/ZuulJobsNamespaceLoopVar.py This new rule becomes active only when loop_var_prefix is defined inside the config and allows user to use dynamic prefix based on role folder name.
ssbarnea
force-pushed
the
0/mock-roles
branch
from
531f670
to
a353dbc
Compare
|
lgtm, I guess if we upgrade ansible-lint in zuul-jobs we can replace the rule with a simple config update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on original custom rule written by @albinvass on
https://opendev.org/zuul/zuul-jobs/blame/branch/master/.rules/ZuulJobsNamespaceLoopVar.py
This new rule becomes active only when loop_var_prefix is defined
inside the config and allows user to use dynamic prefix based
on role folder name.