Drop E suffix when printing rule id #1305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From now on we no longer print E before rule id on parseable and normal printing because it both reduced readability of the text and also because it was misleading, some errors may be only warnings but we always displayed only E. This will also make it easier for us to migrate to text rule ids, which are more human friendly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From now on we no longer print E before rule id on parseable and
normal printing because it both reduced readability of the text
and also because it was misleading, some errors may be only
warnings but we always displayed only E.
This will also make it easier for us to migrate to text rule ids,
which are more human friendly.