Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exclude_paths regression #1313

Merged
merged 1 commit into from Feb 7, 2021
Merged

Fix exclude_paths regression #1313

merged 1 commit into from Feb 7, 2021
+23 −1

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Feb 7, 2021

Fixes: #1311

@ssbarnea ssbarnea added the bug label Feb 7, 2021
@felixfontein
Copy link
Contributor

This still produces the error. I guess the problem is that is_excluded is still broken (see 1. in the issue).

@felixfontein
Copy link
Contributor

It does work now!

@ssbarnea ssbarnea merged commit b866ce2 into master Feb 7, 2021
@ssbarnea ssbarnea deleted the 0/mock-roles branch February 7, 2021 13:01
@felixfontein
Copy link
Contributor

@ssbarnea thanks for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

exclude_paths no longer properly works
2 participants
@ssbarnea @felixfontein