Adds experimental stdin support #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow ansible-lint to perform linting from stdin when filename argument '/dev/stdin' or '-' are given. Keep in mind: - no argument still means auto-detect as I found no reliable way to identify that the tool was used with shell pipes - filename reported is 'stdin', same as flake8 does - received content is assumed to be a playbook, you cannot lint a task file this way. Others are welcomed to propose improvements for detecting the file type based on its content, because we do not have any `filename` available.
webknjaz
reviewed
Feb 15, 2021
Comment on lines
+194
to
+195
| for match in matches: | ||
| for lintable in lintables: |
There was a problem hiding this comment.
How about using an itertools.product() here?
There was a problem hiding this comment.
Not really as I do also have the break.
webknjaz
reviewed
Feb 15, 2021
| if self.kind == "role": | ||
| self.dir = str(self.path.resolve()) | ||
| if str(self.path) in ['/dev/stdin', '-']: | ||
| self.file = NamedTemporaryFile(mode="w+", suffix="playbook.yml") |
There was a problem hiding this comment.
Can it be kept in-memory instead?
There was a problem hiding this comment.
Nope because I do need to feed ansible-playbook --syntax-check a file. The rest of the linter code could work fine with in-memory files, but not ansible itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow ansible-lint to perform linting from stdin when filename arguments as
/dev/stdinor-are given.Keep in mind:
filenameavailable.Fixes: #790