Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite ansible version checking #1383

Merged
merged 1 commit into from Feb 20, 2021
Merged

Rewrite ansible version checking #1383

merged 1 commit into from Feb 20, 2021

Conversation

ssbarnea
Copy link
Member

  • assure we check that ansible python module and ansible cli versions
    are the same
  • print ansible version alongside ansible-lint version
  • fix version version comparison from <= to <

Fixes: #1378

Copy link

@JohnMalmberg JohnMalmberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests good with out the UnboundLocalError being caught.
Tested with ansible==2.9.0 and ansible==2.8.19

src/ansiblelint/_prerun.py Outdated Show resolved Hide resolved
@ssbarnea ssbarnea force-pushed the 0/5.0.2 branch 2 times, most recently from 17911e9 to 1346801 Compare February 19, 2021 16:28
- assure we check that ansible python module and ansible cli versions
  are the same
- print ansible version alongside ansible-lint version
- fix version version comparison from <= to <

Fixes: #1378
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minimum ansible version check fails with stack dump
3 participants