Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention pipx as alternative installer #1520

Merged
merged 1 commit into from Apr 8, 2021
Merged

Mention pipx as alternative installer #1520

merged 1 commit into from Apr 8, 2021

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Apr 7, 2021

No description provided.

Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any strong opinion on this. I'm a bit opposed to recommending third-party tools as you may end up having to deal with people not knowing how to best set up pipx in their systems.

docs/installing.rst Outdated Show resolved Hide resolved
@ssbarnea
Copy link
Member Author

ssbarnea commented Apr 7, 2021

I don't have any strong opinion on this. I'm a bit opposed to recommending third-party tools as you may end up having to deal with people not knowing how to best set up pipx in their systems.

My guess is that using pip correctly is much harder than using pipx. Once they install pipx, I doubt they can get it to misbehave, like we often see with pip (--user, sudo, ....).

Just to have an idea, just yesterday I had one user complaining that installing using pip was failing under centos-7... yeah pip 9.0.3 from py27, something already not supported.

Copy link
Contributor

@tadeboro tadeboro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the external tool does not provide an order of magnitude better user experience, then I am against recommending it. When it comes to Python apps, I tend to instruct users to either install them using the distro's package manager or create a dedicated virtual environment (example: https://github.com/sensu/sensu-go-python#installation). Anything else is just asking for troubles in my experience.

In this case, I would say pipx is not worth it and that we should stick to standard tools.

@ssbarnea
Copy link
Member Author

ssbarnea commented Apr 7, 2021

If the external tool does not provide an order of magnitude better user experience, then I am against recommending it. When it comes to Python apps, I tend to instruct users to either install them using the distro's package manager or create a dedicated virtual environment (example: https://github.com/sensu/sensu-go-python#installation). Anything else is just asking for troubles in my experience.

In this case, I would say pipx is not worth it and that we should stick to standard tools.

I will wait for additional feedback, so I can see if there is a trend or not. Based on current one I am inclined to rewrite the recommendation differently, listing pip3 in example and only mentioning pipx as an alternative.

@ssbarnea ssbarnea changed the title Recommend using pipx to install ansible-lint Mention pipx as alternative installer Apr 8, 2021
@ssbarnea ssbarnea merged commit 1dc3533 into master Apr 8, 2021
@ssbarnea ssbarnea deleted the pipx branch April 8, 2021 18:05
Using pip or pipx
-----------------

You can use either pip3_ or pipx_ to install it, the former one
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.grammarly.com/blog/former-vs-latter/

Suggested change
You can use either pip3_ or pipx_ to install it, the former one
You can use either pip3_ or pipx_ to install it, the latter one

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants