Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for acceptable command options #1544

Merged
merged 18 commits into from May 3, 2021
Merged

Add support for acceptable command options #1544

merged 18 commits into from May 3, 2021

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented May 3, 2021

This PR is meant to reduce the number of false positives when command: is required due to missing module functionality.

E.g. command: systemctl set-default (#682) is acceptable since the Ansible systemd module don't have runlevel support.

Added 'git': 'branch', and 'systemctl': ['set-default', 'show-environment'] as initial examples.

Fixes: #682
Author: @konstruktoid
Closes: #1457

konstruktoid and others added 17 commits March 11, 2021 14:50
Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
…ISSUE682

* 'ISSUE682' of github.com:konstruktoid/ansible-lint:
  Avoid pre-run errors when role-name is disabled (#1459)
  Avoid exception when git is missing (#1456)
  Improve how we determine runtime verbosity
* master:
  More type (2) (#1497)
  More type (#1496)
  Add ability to ignore jinja2 templates (#1494)
  Fix MetaMainHasInfoRule when running from meta dir (#1493)
Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
* master:
  Recommend using pipx to install ansible-lint (#1520)
  Ignore templated files (#1524)
  src/ansiblelint/utils.py: Ensure that the role file is not a file (#1522)
  Fixed docs edit links (#1525)
  Fix role name handling in prerun.py (#1490)
  More type (3) (#1498)
  Retry prepare environment three times before failing (#1517)
  Add ansible-role-bootstrap (#1503)
  Fix meta-incorrect rule to report correctly (#1515)
  Update dependencies (#1516)
  Add DebOps project to eco test pipeline (#1500)
@ssbarnea ssbarnea changed the title Issue682 Add support for acceptable command options May 3, 2021
@ssbarnea ssbarnea merged commit 4de1b71 into master May 3, 2021
@ssbarnea ssbarnea deleted the ISSUE682 branch May 3, 2021 13:24
konstruktoid added a commit to konstruktoid/ansible-role-hardening that referenced this pull request Jan 3, 2022
Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive for 303 when using command module for setting system runlevel
2 participants