Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata tag to the role-name rule #1564

Merged
merged 1 commit into from May 21, 2021

Conversation

noonedeadpunk
Copy link
Contributor

role-name rule is based on the metadata info. Thus, it would be expected
by users to also exclude this task, when -x metadata is set in the
config

Signed-Off-By: Dmitriy Rabotyagov noonedeadpunk@ya.ru

role-name rule is based on the metadata info. Thus, it would be expected
by users to also exclude this task, when `-x metadata` is set in the
config

Signed-Off-By: Dmitriy Rabotyagov <noonedeadpunk@ya.ru>
@noonedeadpunk
Copy link
Contributor Author

Labels check is frustrating for contributors tbh. Or I just don't see/know the way to set it.

@ssbarnea
Copy link
Member

You cannot, only cores can add labels and sadly github does not have a diffetent way to prevent a merge while checking the labels.

role-name is usually meta but not necessarily as it can be determined just by folder name.

So it is meta related but not pure meta. Probably ok to add meta label.

@ssbarnea ssbarnea added the bug label May 21, 2021
@ssbarnea ssbarnea merged commit 127d248 into ansible:master May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants