var-spacing: fix multiline nested JSON false positive #1672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
approved these changes
Jul 16, 2021
VariableHasSpacesRule testing was limited to ensuring that the number of error was matching an expected number. This could have potential limitation where for example a commit prevents an real linting error from being raised and in the same time raises an invalid one. This commit aims at improving this rule's testing by ensuring that errors are raised only on a controlled set of lines. Related to: ansible#1671
This commit adds 4 new tasks in example playbook used for VariableHasSpacesRule testing. One of these rule is a nested multiline JSON object which has its opening and closing brackets spanned on different lines. And this rule raises false positive error. Related to ansible#1671
When using a nested JSON object spanned on multiple lines in a Jinja2 context ansible-lint raises a false positive E206 error. This commit extends the regex in charge of excluding false positive JSON objects so that it handles multiline matching. Fixes ansible#1671
simonkeyd
force-pushed
the
pr/1671-fix-multiline-nested-json-false-positive
branch
from
c278af1
to
b463caf
Compare
|
@ssbarnea I just fixed the CI. PR is all set. |
ssbarnea
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the testing on E206 rule, adds a false positive task in test case and finally fixes multiline nested JSON false positive.
Fixes: #1671