Expand coverage of path globbing #1709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exclude path handling does not pick up very many glob matches. This improves the matching by adding in fnmatch module usage
ssbarnea
approved these changes
Aug 31, 2021
tadeboro
reviewed
Sep 6, 2021
test/TestRunner.py
Outdated
| @@ -76,12 +76,17 @@ def test_runner_exclude_paths(default_rules_collection: RulesCollection) -> None | |||
| assert len(matches) == 0 | |||
|
|
|||
|
|
|||
| def test_runner_exclude_globs(default_rules_collection: RulesCollection) -> None: | |||
| @pytest.mark.parametrize( | |||
| ('exclude_path'), ('**/example.yml', 'examples/**/example.yml') | |||
There was a problem hiding this comment.
Those samples are not the best since they, while being valid globs, are too similar to the extended (wildcard) matches that are supported by the wcmatch library for example. Maybe we should add some more bash-like expressions here? Things like *.yml, etc.
ssbarnea
approved these changes
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exclude path handling does not pick up very many glob matches. This
improves the matching by adding in fnmatch module usage
Fixes: #1561