Make core extra use ansible-core #1720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
reviewed
Sep 7, 2021
webknjaz
reviewed
Sep 7, 2021
webknjaz
reviewed
Sep 7, 2021
webknjaz
reviewed
Sep 7, 2021
tadeboro
approved these changes
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of installing
ansible-basewhencoreextra isused, we will require
ansible-core. When original change wasintroduced few months back we already knew that the future
proof name was
coreso that is with the extra was called assuch.
Users that want to explicitly use ansible 2.10 should avoid using the extra and mention ansible as a separated dependency.
If previous environments already existed with ansible-base installed on them an installation failure will appear as ansible-base needs to be removed before ansible-core is installed. Due to this, this change will only be include in the next
5.2.0release instead of being considered a simple bugfix.Fixes: #1717