Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

Proper version tagging #23

Closed
ruzickap opened this issue Apr 6, 2020 · 8 comments
Closed

Proper version tagging #23

ruzickap opened this issue Apr 6, 2020 · 8 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@ruzickap
Copy link

ruzickap commented Apr 6, 2020

Hello.

Would it be possible to do a proper tagging for this project please?

Maybe good starting point is here: https://github.com/actions/checkout
They are using versions like:

  • v2 -> v2.0.0
  • v4 -> v4.1.0

It would be really handy to use something like v4 instead of specifying the exact version only v4.1.0:

    - uses: ansible/ansible-lint-action@v4

Thank you...

@webknjaz
Copy link
Member

webknjaz commented Apr 8, 2020

I mean, we need to set up automation for this. But yes, it's possible. OTOH, relying on tags/branches is a security disaster for users FTR.

Are you up for contributing this?

@webknjaz webknjaz added the enhancement New feature or request label Apr 8, 2020
@ruzickap
Copy link
Author

ruzickap commented Apr 8, 2020

It should not be so hard.

I'm using https://github.com/haya14busa/action-update-semver for it:

name: update-semver

on:
  release:
    types: [published]
    tags:
      - 'v*.*.*'

jobs:
  update-semver:
    runs-on: ubuntu-18.04
    steps:
      - uses: actions/checkout@v2

      - name: Semver
        uses: haya14busa/action-update-semver@v1
        with:
          major_version_tag_only: true
          github_token: ${{ secrets.github_token }}

The example above ^^^ should be working...

@ruzickap ruzickap mentioned this issue Apr 8, 2020
@webknjaz
Copy link
Member

webknjaz commented Apr 8, 2020

Somebody else suggested https://github.com/technote-space/release-github-actions (in another action pypa/gh-action-pypi-publish#22 (comment)). How does haya14busa/action-update-semver compare to it?

@ruzickap
Copy link
Author

ruzickap commented Apr 8, 2020

No idea...
The goal is to point the latest release of ansible-lint-action to some "sort version".

Using ansible/ansible-lint-action@master is not a good approach.
Using ansible/ansible-lint-action@v1.2.3 is not a good as well, because people will need to change their code every "minor" release.

Feel free to use whatever tool you want...

@jimrazmus
Copy link

I mean, we need to set up automation for this. But yes, it's possible. OTOH, relying on tags/branches is a security disaster for users FTR.

I use dependabot to maintain the versions of the actions I use in my workflows. Doing so facilitates debugging as I can recreate the environment. Using @master compromises that ability.

@cognifloyd
Copy link

@webknjaz Please help me understand this (feel free to point me at a good article/manual/book to read if that's quicker):

OTOH, relying on tags/branches is a security disaster for users FTR.

Are you talking about the possibility of someone getting access to a repo, and adding something unexpected or nefarious in a given branch, or rewriting a given tag? I suppose you could pin with a commit hash instead to mitigate that. Is there something else that makes branches/tags a "security disaster"?

@godzChosen2
Copy link

Thank you

@ssbarnea ssbarnea added this to the v6 milestone Mar 21, 2022
@ssbarnea ssbarnea self-assigned this Mar 21, 2022
@ssbarnea
Copy link
Member

From now one we will try to follow the versions from ansible-lint

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants