Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-log-password rule matches against property not asking for a password #1728

Closed
chazzly opened this issue Sep 22, 2021 · 2 comments
Closed
Labels

Comments

@chazzly
Copy link

chazzly commented Sep 22, 2021

Summary

The no-log-password rule matches against property not asking for a password.

Issue Type
  • Bug Report
Ansible and Ansible Lint details
$ ansible --version
ansible 2.9.10
  config file = None
  configured module search path = ['/home/a850411/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /home/a850411/virtenvs/mole3/lib/python3.6/site-packages/ansible
  executable location = /home/a850411/virtenvs/mole3/bin/ansible
  python version = 3.6.9 (default, Jan 26 2021, 15:33:00) [GCC 8.4.0]

$ ansible-lint --version
ansible-lint 5.0.9 using ansible 2.9.10
  • ansible installation method: pip
  • ansible-lint installation method: pip
STEPS TO REPRODUCE
- name: Lock user
  user:
    name: dummy
    comment: "Dummy User"
    password_lock: true
    shell: /bin/bash
Desired Behaviour

ansible-lint should not error

Actual Behaviour

lint fails with no-log-password:


WARNING  Listing 2 violation(s) that are fatal
no-log-password: password should not be logged.
tasks/main.yml:6 Task/Handler: Lock user

@chazzly chazzly added bug new Triage required labels Sep 22, 2021
@konstruktoid
Copy link
Contributor

Hi @chazzly, could you please try the latest version?
I belive this was fixed in #1562

@ssbarnea ssbarnea removed the new Triage required label Mar 9, 2022
@ssbarnea
Copy link
Member

ssbarnea commented Mar 9, 2022

Closing as fixed.

@ssbarnea ssbarnea closed this as completed Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants