Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the detection of role vars missing role prefix #3750

Merged
merged 3 commits into from
Sep 19, 2023

Conversation

cavcrosby
Copy link
Contributor

Fixes #3714.

@cavcrosby cavcrosby requested a review from a team as a code owner September 19, 2023 18:28
@cavcrosby cavcrosby temporarily deployed to ack September 19, 2023 18:28 — with GitHub Actions Inactive
@ssbarnea ssbarnea temporarily deployed to ack September 19, 2023 20:07 — with GitHub Actions Inactive
@ssbarnea ssbarnea temporarily deployed to ack September 19, 2023 20:08 — with GitHub Actions Inactive
@ssbarnea ssbarnea added the bug label Sep 19, 2023
@ssbarnea ssbarnea temporarily deployed to ack September 19, 2023 20:08 — with GitHub Actions Inactive
@ssbarnea ssbarnea enabled auto-merge (squash) September 19, 2023 20:13
@ssbarnea ssbarnea merged commit eb35080 into ansible:main Sep 19, 2023
20 checks passed
@cavcrosby cavcrosby deleted the fix-role-vars-prefix branch September 19, 2023 20:24
nrdufour added a commit to nrdufour/home-ops that referenced this pull request Oct 3, 2023
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [ansible-lint](https://github.com/ansible/ansible-lint) ([changelog](https://github.com/ansible/ansible-lint/releases)) | minor | `==6.19.0` -> `==6.20.0` |

---

### Release Notes

<details>
<summary>ansible/ansible-lint (ansible-lint)</summary>

### [`v6.20.0`](https://github.com/ansible/ansible-lint/releases/tag/v6.20.0)

[Compare Source](ansible/ansible-lint@v6.19.0...v6.20.0)

#### Minor Changes

-   Respect cgroup CPU limits when running inside containers ([#&#8203;3749](ansible/ansible-lint#3749)) [@&#8203;ssbarnea](https://github.com/ssbarnea)
-   Rename --write option to --fix ([#&#8203;3748](ansible/ansible-lint#3748)) [@&#8203;ssbarnea](https://github.com/ssbarnea)
-   Add auto-fixing implementation for `no-free-form` rule ([#&#8203;3725](ansible/ansible-lint#3725)) [@&#8203;ajinkyau](https://github.com/ajinkyau)
-   Add auto-fixing implementation for `partial-become` rule ([#&#8203;3692](ansible/ansible-lint#3692)) [@&#8203;shatakshiiii](https://github.com/shatakshiiii)
-   Add auto-fixing implementation for `no-jinja-when` rule ([#&#8203;3721](ansible/ansible-lint#3721)) [@&#8203;shatakshiiii](https://github.com/shatakshiiii)

#### Bugfixes

-   Fix the detection of role vars missing role prefix ([#&#8203;3750](ansible/ansible-lint#3750)) [@&#8203;cavcrosby](https://github.com/cavcrosby)
-   Clarify auto-fix arguments use ([#&#8203;3751](ansible/ansible-lint#3751)) [@&#8203;ssbarnea](https://github.com/ssbarnea)
-   Avoid IndexError exception with jinja transform ([#&#8203;3747](ansible/ansible-lint#3747)) [@&#8203;ssbarnea](https://github.com/ssbarnea)
-   Fix docs typo ([#&#8203;3746](ansible/ansible-lint#3746)) [@&#8203;ssbarnea](https://github.com/ssbarnea)
-   Add /bin/bash executable to example correct code for pipefail rule ([#&#8203;3731](ansible/ansible-lint#3731)) [@&#8203;Perdu](https://github.com/Perdu)
-   Properly avoid `pipx` venv path to be included in altered path warning ([#&#8203;3730](ansible/ansible-lint#3730)) [@&#8203;chrysle](https://github.com/chrysle)
-   Fix transform exception with local_action with old syntax ([#&#8203;3743](ansible/ansible-lint#3743)) [@&#8203;ssbarnea](https://github.com/ssbarnea)
-   Support only_upgrade ([#&#8203;3734](ansible/ansible-lint#3734)) [@&#8203;soroshsabz](https://github.com/soroshsabz)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi45Ni4wIiwidXBkYXRlZEluVmVyIjoiMzYuOTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Reviewed-on: https://git.home/nrdufour/home-ops/pulls/97
Co-authored-by: Renovate <renovate@ptinem.io>
Co-committed-by: Renovate <renovate@ptinem.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

var-naming[no-role-prefix] is not detected in a role's vars files
2 participants