Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

false positive no-tag rules for win_lineinfile module #3997

Closed
davorceman opened this issue Jan 26, 2024 · 1 comment · Fixed by #4147
Closed

false positive no-tag rules for win_lineinfile module #3997

davorceman opened this issue Jan 26, 2024 · 1 comment · Fixed by #4147
Assignees
@ssbarnea
Labels
bug

Comments

@davorceman
Copy link

davorceman commented Jan 26, 2024 •
edited

Summary

I have this issue and found that it is resolved with this PR
Seems that is fixed only for lineinfile not win_lineinfile. It would be good to have it implemented there as well

Issue Type
  • Bug Report
ansible-lint --version
ansible-lint 6.22.2 using ansible-core:2.15.8
@davorceman davorceman added bug new Triage required labels Jan 26, 2024
@ssbarnea ssbarnea removed the new Triage required label Jan 31, 2024
@ssbarnea
Copy link
Member

@davorceman Can you please make a PR to also address it for win_lineinfile? Thanks!

@audgirka audgirka removed their assignment May 7, 2024
ssbarnea added a commit that referenced this issue May 9, 2024
@ssbarnea
Allow tabs in win_lineinfile
1daf03c 
Fixes: #3997
@ssbarnea ssbarnea mentioned this issue May 9, 2024
Merged
@ssbarnea ssbarnea self-assigned this May 9, 2024
ssbarnea added a commit that referenced this issue May 9, 2024
@ssbarnea
Allow tabs in win_lineinfile
dbf567e 
Fixes: #3997
ssbarnea added a commit that referenced this issue May 10, 2024
@ssbarnea
Allow tabs in win_lineinfile
c75270d 
Fixes: #3997
ssbarnea added a commit that referenced this issue May 10, 2024
@ssbarnea
Allow tabs in win_lineinfile
77ebb73 
Fixes: #3997
shatakshiiii pushed a commit that referenced this issue May 13, 2024
@ssbarnea @shatakshiiii
Allow tabs in win_lineinfile
ce8c112 
Fixes: #3997
ssbarnea added a commit that referenced this issue May 13, 2024
@ssbarnea
Allow tabs in win_lineinfile
8a0f417 
Fixes: #3997
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ssbarnea ssbarnea

Labels
bug
Projects
🧰 devtools project board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow tabs in win_lineinfile ansible/ansible-lint
3 participants
@ssbarnea @audgirka @davorceman