Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ConnectModal): solve plugin tag hover style display unexpected issue #861

Merged
merged 6 commits into from
May 10, 2024

Conversation

jrr997
Copy link
Collaborator

@jrr997 jrr997 commented May 9, 2024

[中文版模板 / Chinese template]

💡 Background and solution

🔗 Related issue link

close #860

Copy link

vercel bot commented May 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ant-design-web3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 7:06am

Copy link

changeset-bot bot commented May 9, 2024

🦋 Changeset detected

Latest commit: f48afc1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ant-design/web3 Patch
@example/ethers-v5 Patch
@example/ethers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

github-actions bot commented May 9, 2024

Preview is ready

@github-actions github-actions bot added the major label May 9, 2024
@kiner-tang kiner-tang changed the title Fix/plugin tag hover error fix(ConnectModal): solve plugin tag hover style display unexpected issue May 9, 2024
@kiner-tang
Copy link
Member

image 应该不能这么改,改完之后鼠标移入钱包的时候,plugin 没有高亮了。我们应该只让鼠标移入 二维码的时候 plugin 取消高亮,但鼠标在除了二维码之外的钱包项区域, plugin 应该还是要高亮的

@yutingzhao1991
Copy link
Collaborator

不能直接这么删,完整的逻辑应该是:

  • 如果安装了插件,那么 hover 整个 item 的时候应该高亮 plugin
  • 如果没有安装插件,那么 hover 整个 item 的时候应该高亮二维码
  • 如果 hover 二维码,应该只高亮二维码

对应的是点击 item 的逻辑

@github-actions github-actions bot removed the major label May 9, 2024
@jrr997
Copy link
Collaborator Author

jrr997 commented May 9, 2024

是我理解错了

@kiner-tang kiner-tang merged commit da09f06 into ant-design:main May 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] When hovering over the QR code icon, the plugin button should not be highlighted.
4 participants