Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spin size not correct when set fontSize #15206

Closed
1 task
zombieJ opened this issue Mar 5, 2019 · 2 comments · Fixed by #16569
Closed
1 task

Spin size not correct when set fontSize #15206

zombieJ opened this issue Mar 5, 2019 · 2 comments · Fixed by #16569
Labels
Inactive

Comments

@zombieJ
Copy link
Member

zombieJ commented Mar 5, 2019

  • I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link

Edit on CodeSandbox

Steps to reproduce

Open link will see Spin not center aligned.

What is expected?

Center aligned.

What is actually happening?

Not aligned.

Environment Info
antd 3.14.1
React 16.8.0
System Mac
Browser Chrome

It's caused by Spin less: https://github.com/ant-design/ant-design/blob/master/components/spin/style/index.less#L126
It should set as 1em instead of @spin-dot-size directly.
@afc163
Copy link
Member

afc163 commented Mar 5, 2019

Can it drop Spin in this situation?

https://codesandbox.io/s/r7z906rwqm

@zombieJ
Copy link
Member Author

zombieJ commented Mar 5, 2019

Can it drop Spin in this situation?

https://codesandbox.io/s/r7z906rwqm

It's simple demo. You can see complex one: https://codesandbox.io/s/jnr931ylwy

@zombieJ zombieJ mentioned this issue May 13, 2019
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Inactive
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Spin size not correct when set fontSize ant-design/ant-design
4 participants
@afc163 @yutingzhao1991 @zombieJ @ant-design-bot