Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cascader 中 value 添加支持 number 类型 #17407

Closed
1 task done
simdd opened this issue Jul 2, 2019 · 5 comments
Closed
1 task done

cascader 中 value 添加支持 number 类型 #17407

simdd opened this issue Jul 2, 2019 · 5 comments
Labels
good first issue help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. Inactive

Comments

@simdd
Copy link

simdd commented Jul 2, 2019

  • I have searched the issues of this repository and believe that this is not a duplicate.

What problem does this feature solve?

问题描述:

cascader 组件中 value 只支持string,不支持 number

需求

支持 number 类型

相关代码:

https://github.com/ant-design/ant-design/blob/master/components/cascader/index.tsx#L60

如果是设计如此:

 请告诉一下我为什么设计成只支持 string,谢谢

What does the proposed API look like?

支持 number

@simdd simdd changed the title cascader 中 value 支持 number类型 cascader 中 value 只支持 number类型 Jul 2, 2019
@afc163
Copy link
Member

afc163 commented Jul 2, 2019

Could you create a PR to imporove it?

@afc163 afc163 added the help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. label Jul 2, 2019
@hengkx
Copy link
Member

hengkx commented Jul 2, 2019

Let me deal with it. before the encounter also needs number to be converted into string is very difficult

@XianZhengquan
Copy link
Contributor

@simdd 你这个标题改的是不是有歧义啊,只支持number类型,也就是其他类型都不支持了。

@simdd simdd changed the title cascader 中 value 只支持 number类型 cascader 中 value 添加支持 number 类型 Jul 12, 2019
@simdd
Copy link
Author

simdd commented Jul 12, 2019

@simdd 你这个标题改的是不是有歧义啊,只支持number类型,也就是其他类型都不支持了。

修改啦

@afc163
Copy link
Member

afc163 commented May 18, 2020

Thx! @Loogeek #24247

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. Inactive
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants