Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anchor文档中写了offsetBottom, 但实际代码没有相关props #26669

Closed
1 task done
zWingz opened this issue Sep 10, 2020 · 7 comments · Fixed by #26672
Closed
1 task done

Anchor文档中写了offsetBottom, 但实际代码没有相关props #26669

zWingz opened this issue Sep 10, 2020 · 7 comments · Fixed by #26672

Comments

@zWingz
Copy link

zWingz commented Sep 10, 2020

  • I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link

https://ant.design/components/anchor-cn/#API

What is expected?

props正确

What is actually happening?

props不正确

image

image
@ant-design-bot
Copy link
Contributor

Hello @zWingz, your issue has been closed because it does not conform to our issue requirements. Please use the Issue Helper to create an issue, thank you!

你好 @zWingz，为了能够进行高效沟通，我们对 issue 有一定的格式要求，你的 issue 因为不符合要求而被自动关闭。你可以通过 issue 助手 来创建 issue 以方便我们定位错误。谢谢配合！

@yoyo837 yoyo837 reopened this Sep 10, 2020
@yoyo837
Copy link
Contributor

yoyo837 commented Sep 10, 2020 •
edited

#3720 @RaoHai

@hengkx hengkx added 📝 Documentation help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. labels Sep 10, 2020
@ant-design-bot
Copy link
Contributor

Hello @zWingz. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. Appreciate it advance and we are looking forward to your contribution!

你好 @zWingz, 我们完全同意你的提议/反馈，欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支（新特性发到 feature 分支，其他发到 master 分支），务必填写 Pull Request 内的预设模板，提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等，并确保 CI 通过，我们会尽快进行 Review，提前感谢和期待您的贡献！

giphy

@hengkx hengkx removed the Invalid label Sep 10, 2020
@hengkx
Copy link
Member

hengkx commented Sep 10, 2020

不对 看了下 代码里面 有用Affix,他里面有这个属性 但是也没有传递 ，这是算 bug 还是 文档 @afc163

@hengkx hengkx removed help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. 📝 Documentation labels Sep 10, 2020
@afc163
Copy link
Member

afc163 commented Sep 10, 2020

文档问题，第一个版本就没有 offsetBottom.

ef720db#diff-1f2d30d0addbfbbde130c7078d7eb3e0R21

afc163 referenced this issue Sep 10, 2020
@RaoHai
anchor
ef720db
@muzea
Copy link
Contributor

muzea commented Sep 10, 2020

需要在实现里面补充上这个属性吗？（周六团建，周末可以搞一下）

@hengkx hengkx mentioned this issue Sep 10, 2020
Merged
19 tasks
@afc163
Copy link
Member

afc163 commented Sep 10, 2020

@muzea 欢迎啊。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: remove Anchor not use api ant-design/ant-design
6 participants
@afc163 @yoyo837 @muzea @hengkx @zWingz @ant-design-bot