Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Large <Button>'s icon size is incorrect with hashed: false #47132

Closed
xsjcTony opened this issue Jan 24, 2024 · 4 comments · Fixed by #46609
Closed

Large <Button>'s icon size is incorrect with hashed: false #47132

xsjcTony opened this issue Jan 24, 2024 · 4 comments · Fixed by #46609
Labels
🐛 Bug Ant Design Team had proved that this is a bug.

Comments

@xsjcTony
Copy link
Contributor

xsjcTony commented Jan 24, 2024 •
edited

Reproduction link

https://stackblitz.com/edit/vitejs-vite-cqpaku?file=src%2FApp.tsx

Steps to reproduce

use hashed: false in <ConfigProvider>.

cssVar: true by itself is totally fine, but as long as you use hashed: off, the style overwrite is missing.

It's recommended by the doc to turn off hashed if cssVar is on. https://ant.design/docs/react/css-variables-cn#%E5%85%B3%E9%97%AD-hash

What is expected?

Icon size should be identical to font size.

What is actually happening?

CSS overwrite from ant-btn-lg is missing

Environment Info
antd 5.13.2
React 18.2.0
System Windows 11
Browser Chrome 120

Maybe check for other button size as well, I didn't test small

✅可以使用中文
@stackblitz StackBlitz
Copy link

stackblitz bot commented Jan 24, 2024

Fix this issue in StackBlitz Codeflow Start a new pull request in StackBlitz Codeflow.

@MadCcc
Copy link
Member

MadCcc commented Jan 24, 2024

Currently style without hash has some problem indeed.
#46609
We will make it same as hashed.

@xsjcTony
Copy link
Contributor Author

Thanks. I'll temporarily turn hashed on. Is there any issue I can track of that once hashed issues are all resolved, or do we keep this open?

@MadCcc
Copy link
Member

MadCcc commented Jan 24, 2024

We will keep this issue open until styles are fixed

@MadCcc MadCcc added 🐛 Bug Ant Design Team had proved that this is a bug. and removed unconfirmed labels Jan 24, 2024
This was referenced Jan 29, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 Bug Ant Design Team had proved that this is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: component style without hash ant-design/ant-design
2 participants
@MadCcc @xsjcTony