Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What to display Table.EXPAND_COLUMN in children column? #48651

Open
UnderMountain96 opened this issue Apr 26, 2024 · 2 comments
Open

What to display Table.EXPAND_COLUMN in children column? #48651

UnderMountain96 opened this issue Apr 26, 2024 · 2 comments
Labels
💡 Feature Request help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.

Comments

@UnderMountain96
Copy link

UnderMountain96 commented Apr 26, 2024

Reproduction link

https://ant.design/components/table#expandable

Steps to reproduce

This sample is not working, it displays expandIconColumnIndex=0 and creates an empty column in the desired position:

 const columns = [
        // here display expand column
        {
            title: 'ID',
            dataIndex: 'id',
            key: 'id',
        },
        {
            title: 'Created_at',
            dataIndex: 'created_at',
            key: 'created_at',
        },
        {
            title: 'Publication',
            children: [
                {
                    title: 'Title',
                    dataIndex: 'title',
                    key: 'title',
                },
                {
                    title: 'Author',
                    dataIndex: 'author',
                    key: 'author',
                },
                Table.EXPAND_COLUMN, // here display  empty column
            ],
        },
        {
            title: 'Note',
            dataIndex: 'note',
            key: 'note',
        },
       ]

What is expected?

Displays expand column in children column "Publication"
Columns -> 'Publication' -> EXPAND_COLUMN

What is actually happening?

Displays 2 column, first column of index 0 default expand column, second column of index 4 empty

Environment Info
antd 5.16.4
React React 18.2.0
System Windows 11
Browser Google Chrome
@zombieJ
Copy link
Member

zombieJ commented Apr 26, 2024

Table.EXPAND_COLUMN not support as sub column yet.

@zombieJ zombieJ added help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. 💡 Feature Request and removed unconfirmed labels Apr 26, 2024
Copy link
Contributor

Hello @UnderMountain96. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution!

你好 @UnderMountain96,我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支(新特性发到 feature 分支,其他发到 master 分支),务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献。

giphy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡 Feature Request help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.
Projects
None yet
Development

No branches or pull requests

2 participants