Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Cascader): Should show not found content when options.length is 0 #17538

Merged
merged 1 commit into from Jul 9, 2019

Conversation

dengfuping
Copy link
Contributor

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👻 What's the background?

💡 Solution

📝 Changelog

Language Changelog
🇺🇸 English 🐞 Fix Cascader's notFoundContent not showing when options' length is 0. #17513
🇨🇳 Chinese 🐞 修复 Cascader 组件在 options 为空时不展示空内容的问题。#17513

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

netlify bot commented Jul 9, 2019

Deploy preview for ant-design ready!

Built with commit db88111

https://deploy-preview-17538--ant-design.netlify.com

@dengfuping dengfuping requested review from zombieJ and afc163 July 9, 2019 03:28
options = this.generateFilteredOptions(prefixCls, renderEmpty);
}
} else {
const names: FilledFieldNamesType = getFilledFieldNames(this.props);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已经返回这个类型了 不需要再指定了

@codecov
Copy link

codecov bot commented Jul 9, 2019

Codecov Report

Merging #17538 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17538   +/-   ##
=======================================
  Coverage   96.04%   96.04%           
=======================================
  Files         267      267           
  Lines        7430     7430           
  Branches     2061     2061           
=======================================
  Hits         7136     7136           
  Misses        292      292           
  Partials        2        2
Impacted Files Coverage Δ
components/cascader/index.tsx 97.07% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 905b38f...db88111. Read the comment docs.

@dengfuping dengfuping merged commit 85d81e7 into master Jul 9, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-cascader-notFoundContent branch July 9, 2019 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cascader notFoundContent not work?
3 participants