Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Typescript definition of CascaderOptionType missing some fields #17555 #17581

Merged
merged 1 commit into from Jul 11, 2019

Conversation

MrHeer
Copy link
Contributor

@MrHeer MrHeer commented Jul 11, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👻 What's the background?

solve #17555

💡 Solution

add typescript definition of CascaderOptionType missing fields

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Jul 11, 2019

Deploy preview for ant-design ready!

Built with commit 7e4e5a8

https://deploy-preview-17581--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Jul 11, 2019

Codecov Report

Merging #17581 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17581      +/-   ##
==========================================
- Coverage   96.08%   96.04%   -0.05%     
==========================================
  Files         267      267              
  Lines        7430     7430              
  Branches     2075     2034      -41     
==========================================
- Hits         7139     7136       -3     
- Misses        289      292       +3     
  Partials        2        2
Impacted Files Coverage Δ
components/cascader/index.tsx 97.07% <ø> (ø) ⬆️
components/_util/wave.tsx 85.84% <0%> (-2.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e629da...7e4e5a8. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jul 11, 2019

Codecov Report

Merging #17581 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17581      +/-   ##
==========================================
- Coverage   96.08%   96.04%   -0.05%     
==========================================
  Files         267      267              
  Lines        7430     7430              
  Branches     2075     2034      -41     
==========================================
- Hits         7139     7136       -3     
- Misses        289      292       +3     
  Partials        2        2
Impacted Files Coverage Δ
components/cascader/index.tsx 97.07% <ø> (ø) ⬆️
components/_util/wave.tsx 85.84% <0%> (-2.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e629da...7e4e5a8. Read the comment docs.

@afc163 afc163 changed the title Fix: Typescript definition of CascaderOptionType missing some fields #17555 fix: Typescript definition of CascaderOptionType missing some fields #17555 Jul 11, 2019
@afc163 afc163 merged commit 79bff3f into ant-design:master Jul 11, 2019
@MrHeer MrHeer deleted the fix-#17555 branch July 11, 2019 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants