Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support updating message content with a unique key #18678

Merged
merged 1 commit into from Sep 25, 2019
Merged

feat: support updating message content with a unique key #18678

merged 1 commit into from Sep 25, 2019

Conversation

wzhudev
Copy link
Contributor

@wzhudev wzhudev commented Sep 5, 2019 •
edited by afc163

close #18621

🤔 这个变动的性质是？

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 组件样式改进
  • TypeScript 定义更新
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动（是关于什么的改动？）

🔗 相关 Issue

#10320

💡 需求背景和解决方案

#18621

📝 更新日志怎么写？

语言 更新描述
🇺🇸 英文 Support updating message content with unique key
🇨🇳 中文 支持通过唯一的 key 来更新 message 的内容
  • 中文（可选）:

☑️ 请求合并前的自查清单

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

View rendered components/message/demo/update.md
View rendered components/message/index.en-US.md
View rendered components/message/index.zh-CN.md

@netlify
Copy link

netlify bot commented Sep 5, 2019 •
edited

Deploy preview for ant-design ready!

Built with commit b9a30ad

https://deploy-preview-18678--ant-design.netlify.com

@buildsize
Copy link

buildsize bot commented Sep 5, 2019 •
edited

File name Previous Size New Size Change
package-lock.json 848.78 KB 847.56 KB -1.22 KB (0%)

dengfuping
dengfuping reviewed Sep 5, 2019
View reviewed changes
components/message/index.tsx Outdated Show resolved Hide resolved
components/message/demo/update.md Outdated Show resolved Hide resolved
components/message/demo/update.md Outdated Show resolved Hide resolved
@dengfuping
Copy link
Contributor

  • 还需要更新下 snapshot。
$ npm test -- -u

@codecov
Copy link

codecov bot commented Sep 5, 2019 •
edited

Codecov Report

Merging #18678 into feature will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #18678      +/-   ##
===========================================
+ Coverage    96.95%   96.96%   +<.01%     
===========================================
  Files          281      281              
  Lines         7596     7601       +5     
  Branches      2133     2136       +3     
===========================================
+ Hits          7365     7370       +5     
  Misses         229      229              
  Partials         2        2
Impacted Files Coverage Δ
components/message/index.tsx 94.28% <100%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a40b54a...b9a30ad. Read the comment docs.

MrHeer
MrHeer previously approved these changes Sep 5, 2019
View reviewed changes
dengfuping
dengfuping previously approved these changes Sep 6, 2019
View reviewed changes
@dengfuping
Copy link
Contributor

  • @wendzhue Could you rebase it to make commit history clean?

@wzhudev wzhudev changed the title ✨ support updating message content with a unique key feat: support updating message content with a unique key Sep 6, 2019
@wzhudev
Copy link
Contributor Author

wzhudev commented Sep 12, 2019

  • @wendzhue Could you rebase it to make commit history clean?

Done. Please review again.

@wzhudev
Copy link
Contributor Author

wzhudev commented Sep 16, 2019

@dengfuping Ping.

@yoyo837 yoyo837 requested a review from afc163 September 19, 2019 16:13
@weekly-digest weekly-digest bot mentioned this pull request Sep 22, 2019
Closed
@wzhudev
Copy link
Contributor Author

wzhudev commented Sep 24, 2019

@afc163 Ping~

@afc163
Copy link
Member

afc163 commented Sep 25, 2019

#18987

我修一下用例，一会 rebase 一下 feature 就好。

@afc163
Copy link
Member

afc163 commented Sep 25, 2019

/rebase

yoyo837
yoyo837 requested changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@yoyo837 yoyo837 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

预计合入3.24.0

✨ support updating message content with a unique key
b9a30ad 
close #18621

fix: fix demo

docs: change key api version number

docs: fix docs
@yoyo837 yoyo837 self-requested a review September 25, 2019 04:03
@afc163
Copy link
Member

afc163 commented Sep 25, 2019

可以帮忙把主楼的 changelog 写的更详实一点，包括支持 object 参数这块。

@afc163 afc163 merged commit 53b3c5a into ant-design:feature Sep 25, 2019
@wzhudev wzhudev deleted the message-key branch September 25, 2019 04:45
@afc163 afc163 mentioned this pull request Sep 28, 2019
Closed
1 task
@weekly-digest weekly-digest bot mentioned this pull request Sep 29, 2019
Closed
@afc163
Copy link
Member

afc163 commented Oct 14, 2019

close #10320

@wzhudev wzhudev mentioned this pull request Oct 16, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Nov 19, 2019
Closed
@yoyo837 yoyo837 mentioned this pull request Nov 27, 2019
Closed
1 task
@Aemple Aemple mentioned this pull request Nov 27, 2019
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afc163 afc163 afc163 approved these changes

@yoyo837 yoyo837 yoyo837 approved these changes

@dengfuping dengfuping dengfuping left review comments

@MrHeer MrHeer MrHeer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wzhudev @dengfuping @afc163 @yoyo837 @MrHeer