Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Anchor): add onChange prop #18715

Merged
merged 3 commits into from Sep 6, 2019
Merged

feat(Anchor): add onChange prop #18715

merged 3 commits into from Sep 6, 2019

Conversation

shaodahong
Copy link
Member

@shaodahong shaodahong commented Sep 6, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

Fixed #18655

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Listening for anchor link change
🇨🇳 Chinese 监听锚点链接改变

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/anchor/demo/onChange.md
View rendered components/anchor/demo/targetOffset.md
View rendered components/anchor/index.en-US.md
View rendered components/anchor/index.zh-CN.md

@netlify
Copy link

netlify bot commented Sep 6, 2019

Deploy preview for ant-design ready!

Built with commit fbd04b3

https://deploy-preview-18715--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Sep 6, 2019

Codecov Report

Merging #18715 into feature will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #18715      +/-   ##
===========================================
+ Coverage    96.74%   96.78%   +0.04%     
===========================================
  Files          280      280              
  Lines         7552     7557       +5     
  Branches      2104     2105       +1     
===========================================
+ Hits          7306     7314       +8     
+ Misses         244      241       -3     
  Partials         2        2
Impacted Files Coverage Δ
components/anchor/Anchor.tsx 94.61% <100%> (+0.21%) ⬆️
components/_util/wave.tsx 88.46% <0%> (+2.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e59284...fbd04b3. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Sep 6, 2019

Codecov Report

Merging #18715 into feature will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #18715      +/-   ##
===========================================
+ Coverage    96.74%   96.78%   +0.04%     
===========================================
  Files          280      280              
  Lines         7552     7557       +5     
  Branches      2104     2105       +1     
===========================================
+ Hits          7306     7314       +8     
+ Misses         244      241       -3     
  Partials         2        2
Impacted Files Coverage Δ
components/anchor/Anchor.tsx 94.61% <100%> (+0.21%) ⬆️
components/_util/wave.tsx 88.46% <0%> (+2.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e59284...fbd04b3. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants