New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add: Typography mixins. add: Created typography variables (margin, fo… #18746
add: Typography mixins. add: Created typography variables (margin, fo… #18746
Conversation
Deploy preview for ant-design ready! Built with commit cea0a9e |
Codecov Report
@@ Coverage Diff @@
## feature #18746 +/- ##
========================================
Coverage 96.93% 96.93%
========================================
Files 281 281
Lines 7576 7576
Branches 2073 2115 +42
========================================
Hits 7344 7344
Misses 230 230
Partials 2 2 Continue to review full report at Codecov.
|
Sorry for no responding for a long time. If you are sure those changes are within your expectations, then run |
Please drop all your unrelated changes and rebase feature to fix ci. |
8dd6be2
to
84dc4c2
Compare
…nt-weight). moved: Typography internal variables
84dc4c2
to
5657145
Compare
components/style/themes/default.less
Outdated
@@ -681,3 +681,7 @@ | |||
// Typography | |||
// --- | |||
@typography-title-font-weight: 600; | |||
@typography-title-margin-top: 1.2em; | |||
@typography-title-margin-right: 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need @typography-title-margin-right
and @typography-title-margin-left
, drop them and make it hard coded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then it will be impossible to use the margin in the theming. Why do you need to hardcode this? My projects require margin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any neccessary of setting margin-left
and margin-right
to headings, could you point out for me by examples?
/rebase |
…nt-weight). moved: Typography internal variables
🤔 This is a ...
🔗 Related issue link
#18669
There is no way to fully customize a component.
💡 Background and solution
Created new variables for headings. Moved exists variables to default variables file. Created mixins for extends headings style.
📝 Changelog
@typography-title-margin-top
and@typography-title-margin-bottom
.☑️ Self Check before Merge