Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Input.Search): add loading prop #18771

Merged
merged 4 commits into from Sep 12, 2019
Merged

feat(Input.Search): add loading prop #18771

merged 4 commits into from Sep 12, 2019

Conversation

shaodahong
Copy link
Member

@shaodahong shaodahong commented Sep 11, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

Fixed #14538

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English add search box loading prop
🇨🇳 Chinese 新增搜索框 loading prop

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/input/demo/search-input-loading.md
View rendered components/input/index.en-US.md
View rendered components/input/index.zh-CN.md

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

netlify bot commented Sep 11, 2019

Deploy preview for ant-design ready!

Built with commit 93477a4

https://deploy-preview-18771--ant-design.netlify.com

@buildsize
Copy link

buildsize bot commented Sep 11, 2019

File name Previous Size New Size Change
package-lock.json 851.16 KB 848.68 KB -2.48 KB (0%)

@codecov
Copy link

codecov bot commented Sep 11, 2019

Codecov Report

Merging #18771 into feature will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #18771      +/-   ##
===========================================
+ Coverage    96.78%   96.78%   +<.01%     
===========================================
  Files          281      281              
  Lines         7548     7558      +10     
  Branches      2102     2064      -38     
===========================================
+ Hits          7305     7315      +10     
  Misses         241      241              
  Partials         2        2
Impacted Files Coverage Δ
components/input/Search.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8af697...93477a4. Read the comment docs.

components/input/Search.tsx Outdated Show resolved Hide resolved
@afc163
Copy link
Member

afc163 commented Sep 12, 2019

还有 loading 时不再触发 onSearch 和其他搜索交互,类似 Button 的 loading,可以用于防抖。

@afc163 afc163 merged commit 5cd01d0 into ant-design:feature Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants