Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: TreeSelect removeIcon and clearIcon not working #18949

Merged
merged 9 commits into from Sep 23, 2019
Merged

fix: TreeSelect removeIcon and clearIcon not working #18949

merged 9 commits into from Sep 23, 2019

Conversation

sosohime
Copy link
Contributor

@sosohime sosohime commented Sep 23, 2019 •
edited by afc163

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #18870

💡 Background and solution

支持传入 removeIcon 和 clearIcon

📝 Changelog

Language Changelog
🇺🇸 English Fix TreeSelect removeIcon and clearIcon not working.
🇨🇳 Chinese

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Sep 23, 2019 •
edited

Deploy preview for ant-design ready!

Built with commit 3ef8a5c

https://deploy-preview-18949--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Sep 23, 2019 •
edited

Codecov Report

Merging #18949 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18949      +/-   ##
==========================================
+ Coverage   96.92%   96.93%   +<.01%     
==========================================
  Files         281      281              
  Lines        7554     7557       +3     
  Branches     2105     2110       +5     
==========================================
+ Hits         7322     7325       +3     
  Misses        230      230              
  Partials        2        2
Impacted Files Coverage Δ
components/tree-select/index.tsx 95.83% <100%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 133577f...3ef8a5c. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Sep 23, 2019 •
edited

可以加个测试用例以免后面改挂。

@sosohime
Copy link
Contributor Author

done

@afc163 afc163 changed the title feat: TreeSelect support removeIcon and clearIcon fix: TreeSelect removeIcon and clearIcon not working Sep 23, 2019
@afc163 afc163 merged commit 02ed4bd into ant-design:master Sep 23, 2019
afc163 pushed a commit that referenced this pull request Sep 25, 2019
@sosohime @afc163
fix: TreeSelect removeIcon and clearIcon not working (#18949)
e511e50 
* add tree-select async demo

* TreeSelect支持clearIcon和removeIcon

* remove docs and demo

* run test

* clear code

* add ui test
@weekly-digest weekly-digest bot mentioned this pull request Sep 29, 2019
Closed
@ikobe-zz ikobe-zz mentioned this pull request Sep 29, 2019
Merged
14 tasks
@snyk-bot snyk-bot mentioned this pull request Oct 8, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Oct 23, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Nov 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afc163 afc163 afc163 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TreeSelect shoud support removeIcon property
2 participants
@sosohime @afc163