feat: Add sortColumn to title render #19012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update docs Update TS interface Add null Fix lint error
|
Deploy preview for ant-design ready! Built with commit 7053162 |
This was referenced Sep 26, 2019
Codecov Report
@@ Coverage Diff @@
## feature #19012 +/- ##
===========================================
- Coverage 96.96% 96.96% -0.01%
===========================================
Files 281 281
Lines 7609 7601 -8
Branches 2094 2136 +42
===========================================
- Hits 7378 7370 -8
Misses 229 229
Partials 2 2
Continue to review full report at Codecov.
|
|
conflict |
afc163
changed the title
afc163
approved these changes
Sep 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19007
馃 This is a ...
馃敆 Related issue link
#19007
Title render function is missing information about exactly which column is currently sorted. This is limiting when trying to render a custom sorter.
馃挕 Background and solution
Solution is to send the sortColumn that is stored in the table state. This way the user can infer which column is currently sorted while implementing the title render function.
馃摑 Changelog
Title render function argument object now contains a new key, sortColumn.
鈽戯笍 Self Check before Merge
View rendered components/table/index.en-US.md
View rendered components/table/index.zh-CN.md