Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ConfigProvider miss in tree shaking #19115

Merged
merged 1 commit into from Oct 8, 2019
Merged

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Oct 8, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #19030
close #19086

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix moment in ConfigProvider can not be tree shaking.
🇨🇳 Chinese 修复 ConfigProvider 中的 moment 不能被 tree shaking 的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@pr-triage pr-triage bot removed the PR: unreviewed label Oct 8, 2019
@netlify
Copy link

netlify bot commented Oct 8, 2019

Deploy preview for ant-design ready!

Built with commit 345dbb5

https://deploy-preview-19115--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Oct 8, 2019

Codecov Report

Merging #19115 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #19115   +/-   ##
=======================================
  Coverage   97.32%   97.32%           
=======================================
  Files         281      282    +1     
  Lines        7548     7548           
  Branches     2067     2110   +43     
=======================================
  Hits         7346     7346           
  Misses        201      201           
  Partials        1        1
Impacted Files Coverage Δ
components/config-provider/index.tsx 96.96% <ø> (-0.4%) ⬇️
components/config-provider/context.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0c90f4...345dbb5. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant