Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: improve Slider component handle style #19120

Merged
merged 1 commit into from Oct 9, 2019
Merged

improvement: improve Slider component handle style #19120

merged 1 commit into from Oct 9, 2019

Conversation

shaodahong
Copy link
Member

@shaodahong shaodahong commented Oct 8, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

Fixed #19073
Ref: #19119

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English -
🇨🇳 Chinese 修复 Slider 组件设置 handle 大小后定位错误的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Oct 8, 2019

Deploy preview for ant-design ready!

Built with commit 6f28b98

https://deploy-preview-19120--ant-design.netlify.com

@buildsize
Copy link

buildsize bot commented Oct 8, 2019

File name Previous Size New Size Change
package-lock.json 849.92 KB 901.96 KB 52.03 KB (6%)

@afc163
Copy link
Member

afc163 commented Oct 8, 2019

和升级 rc-slider 关系不大,就是 Slider 本身的问题。

@shaodahong
Copy link
Member Author

和升级 rc-slider 关系不大,就是 Slider 本身的问题。

嗯,相对于 feature 来说是 fix,因为 feature 分支的 slider 默认情况下就是坏的,对于 master 来说不是,算是 bug 或者优化吧

@codecov
Copy link

codecov bot commented Oct 8, 2019

Codecov Report

Merging #19120 into feature will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #19120   +/-   ##
========================================
  Coverage    97.76%   97.76%           
========================================
  Files          281      281           
  Lines         7605     7605           
  Branches      2135     2090   -45     
========================================
  Hits          7435     7435           
  Misses         170      170

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a877db7...6f28b98. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Oct 8, 2019

changelog 要针对已发布版本的角度来说,分支上当前的情况不是用户面临的真实问题。

@shaodahong shaodahong changed the title fix: upgrade rc-slider cause handle move exception improvement: improve Slider handle style Oct 8, 2019
@auto-add-label auto-add-label bot added improvement improve some features and removed bug labels Oct 8, 2019
@shaodahong shaodahong changed the title improvement: improve Slider handle style improvement: improve Slider compoent handle style Oct 8, 2019
@shaodahong shaodahong changed the title improvement: improve Slider compoent handle style improvement: improve Slider component handle style Oct 8, 2019
@afc163
Copy link
Member

afc163 commented Oct 9, 2019

image

提交 PR 时自检一下,勾掉这里所有的勾。

@shaodahong
Copy link
Member Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement improve some features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants